Only close server when errno is not EINTR#23209
Merged
Conversation
Member
|
To be honest I don't understand the details here. WOuld need to start from scratch. Let's see if @julianoes or @bkueng have the context. |
bkueng
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved Problem
When I try to run a startup script I found that the system() call for that startup script was triggering a daemon server error that shuts down the socket early. Looks like another developer had handled this case by trying to ignore the specific errno for that system() triggered error, but left the
breakof that socket while loop outside of that errno check.Solution
Moved
breakinto the if errno checkChangelog Entry
For release notes: