Fix build error in Xcode 13. #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change how MetricsCallbackWrapper wraps its value because enum cases with associated types can not be marked as unavailable with @available in Xcode 13/Swift 5.5
|
@dazmuda can you help us get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enum cases with associated types can no longer be marked as unavailable with @available in Xcode 13/Swift 5.5, this is causing a build break in
MetricsCallbackWrapper.This PR changes
MetricsCallbackWrapperto be a struct with a privateAny?value that is unwrapped asMetricsCallback?when needed. The usage is the same so no other code changes are required.Tests pass on Xcode 12.5 and 13b2.