-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Misc: use std::lock_guard #13573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Misc: use std::lock_guard #13573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F0bes
requested changes
Nov 20, 2025
Member
F0bes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename the commit to include a prefix.
Commits like these are difficult to prefix since they touch code in multiple different places.
Just prepending "Misc:" is good enough 👍
TellowKrinkle
approved these changes
Nov 21, 2025
F0bes
approved these changes
Nov 21, 2025
Hancock33
added a commit
to Hancock33/batocera.piboy
that referenced
this pull request
Nov 23, 2025
----------------------------------------------------------------------------------------------------- batocera-controlcenter.mk d6ff6c604b9b8d100ac6e06e6e96f307f5529c0e # Version: Commits on Nov 21, 2025 ----------------------------------------------------------------------------------------------------- Tabs, footer and tons of optimizations, --------------------------------------------------------------------------------------- amiberry.mk db4cc1f03a33878e558584b43c60ddc3a39bec83 # Version: Commits on Nov 20, 2025 --------------------------------------------------------------------------------------- fix typo (#1734), ----------------------------------------------------------------------------------- cemu.mk 1382ee0381919e97b211a1908722581c51091dc6 # Version: Commits on Nov 21, 2025 ----------------------------------------------------------------------------------- build/cmake: Clean up target_link_libraries (#1726), ------------------------------------------------------------------------------------------ dolphin-emu.mk 4f30aaf1ca1ba410904422e55e2a14012ce8163e # Version: Commits on Nov 20, 2025 ------------------------------------------------------------------------------------------ Merge pull request #13152 from Naim2000/sdlock SDIO: report write lock status, ------------------------------------------------------------------------------------------ duckstation.mk f7e6c20fedc1d3793e66d15c9291dd2016c0893b # Version: Commits on Nov 21, 2025 ------------------------------------------------------------------------------------------ CMake: Bump Qt version requirement, ----------------------------------------------------------------------------------- eden.mk 61f3ce643c59bc4f6a657af73d4953de012523cd # Version: Commits on Nov 21, 2025 ----------------------------------------------------------------------------------- [android] Fix build id (#3066) -------------------------------------------------------------------------------------- flycast.mk 5bce763f66d77831604cded71b4435f141fa9f54 # Version: Commits on Nov 21, 2025 -------------------------------------------------------------------------------------- Merge remote-tracking branch 'origin/dev', ---------------------------------------------------- pcsx2.mk v2.5.316 # Version: Commits on Nov 21, 2025 ---------------------------------------------------- - [Misc: use std::lock_guard](PCSX2/pcsx2#13573) , ------------------------------------------------------------------------------------ rpcs3.mk 9deb6cd4fa373b5fd0883a077943b9a25c46541d # Version: Commits on Nov 21, 2025 ------------------------------------------------------------------------------------ Fix ppu_register_function_at with unaligned parameters (#17718) This fixes some crashes in interpreter mode when calling functions like `sys_dbg_write_process_memory` to write data which may not be an instruction. --------- Co-authored-by: Elad <[email protected]>, ----------------------------------------------------------------------------------------- supermodel.mk 3e94dd09a23f3f90c99713f5af34532e20dd9db7 # Version: Commits on Nov 20, 2025 ----------------------------------------------------------------------------------------- Merge branch 'master' of https://github.com/trzy/Supermodel, -------------------------------------------------------------------------------------------- supermodel-es.mk f4e0cbdc034d955d687d067154e70796766eb1cb # Version: Commits on Nov 20, 2025 -------------------------------------------------------------------------------------------- 0.3a-3e94dd0, ------------------------------------------------- vice.mk r45864 # Version: Commits on Nov 21, 2025 ------------------------------------------------- fix vice_dynlib_ (windows) functions for unicode builds, patch by Carlo Bramini git-svn-id: https://svn.code.sf.net/p/vice-emu/code/trunk@45864 379a1393-f5fb-40a0-bcee-ef074d9b53f7, ------------------------------------------------------------------------------------- ikemen.mk ae46c5ae166dede61a4987ccd425eaa4599bfc17 # Version: Commits on Nov 21, 2025 ------------------------------------------------------------------------------------- Merge pull request #2892 from ikemen-engine/dependabot/github_actions/actions/checkout-6 build(deps): bump actions/checkout from 5 to 6, --------------------------------------------------------------- ruffle.mk nightly-2025-11-21 # Version: Commits on Nov 21, 2025 --------------------------------------------------------------- ## What's Changed * build(deps): bump the cargo-minor group across 1 directory with 3 updates by @dependabot[bot] in ruffle-rs/ruffle#22290 **Full Changelog**: ruffle-rs/ruffle@nightly-2025-11-20...nightly-2025-11-21, -------------------------------------------------------------------------------------- scummvm.mk 99e769b8077fe3f88596657f54fc06d7ba1c3713 # Version: Commits on Nov 21, 2025 -------------------------------------------------------------------------------------- ALCACHOFA: Fix room transitions when examining items, --------------------------------------------------------------------------------------- thextech.mk f491cfb3f0d186a54a4eedb2b408b9393ab00145 # Version: Commits on Nov 21, 2025 --------------------------------------------------------------------------------------- UpdateGraphics: move vScreen fader below HUD, ----------------------------------------------------------------------------------------- rpi-eeprom.mk 801aeb77c5278062c930d2f0992e5f8d14fd4fab # Version: Commits on Nov 21, 2025 ----------------------------------------------------------------------------------------- pieeprom-2025-11-21: 2711: recovery: Restore recovery_wait option (latest) * recovery: Restore recovery_wait option Restore the recovery_wait config.txt option. If this option is set then recovery.bin will not rename itself or reboot. Instead flash the activity LED on completion. This option can be useful when creating an SD card to erase the EEPROM or program the RPIBOOT gpio on multiple devices. If recovery_wait=1 and recovery.bin is run from the SD card then indicate success of erase_eeprom=1 or program_rpiboot_gpio=N was set instead of requiring the EEPROM to be updated. * Manufacture test updates for SDRAM., ---------------------------------------------------------------------------------------- pironman5.mk 0902a2debb3f041c87d3554d26608379ec80a11d # Version: Commits on Nov 21, 2025 ---------------------------------------------------------------------------------------- build: update version to 1.2.22 Remove alpha tag from version as we're moving to stable release, -------------------------------------------------------------------------------------- aic8800.mk 5220943ea16e465d576ec44d12e7d709cff36ebd # Version: Commits on Nov 21, 2025 -------------------------------------------------------------------------------------- Merge pull request #60 from radxa-pkg/dependabot/github_actions/actions/download-artifact-6 chore(deps): bump actions/download-artifact from 5 to 6, ------------------------------------------------------------------------------------ box64.mk cc389b3ec3631f1a3ce7c90b14764b33802ef209 # Version: Commits on Nov 21, 2025 ------------------------------------------------------------------------------------ [RCFILE] Updated an obsolete steam option (#3201), --------------------------------------------------------------------------------------- corsixth.mk d3ab53a0d43d666accff830f7cbfe3fb1bb943f1 # Version: Commits on Nov 21, 2025 --------------------------------------------------------------------------------------- patch: @@ -3,7 +3,7 @@ name: Bug report description: Create a report to help us improve title: \[Bug] Give a summary of the problem\ -labels: [\bug\] +type: Bug ### Questions # What happened? ------------------------------------------------------------------------------------------- jazz2-native.mk 09123bd8ed7593da0e6b977cca3751504bc8a6e9 # Version: Commits on Nov 21, 2025 ------------------------------------------------------------------------------------------- Added Hungarian string for \Continuous Jump\ (#122), ---------------------------------------------------------------------------------------- openmohaa.mk 8df4c828557c28e0259cd558123c2f83fad69e05 # Version: Commits on Nov 20, 2025 ---------------------------------------------------------------------------------------- docs(contributing): state that English must be used when writing, ----------------------------------------------------------------------------------- rott.mk 2a0b8be0b505ce0b34fd100bf21521ec8bd689fb # Version: Commits on Nov 21, 2025 ----------------------------------------------------------------------------------- Remove IS8250 stuff, ---------------------------------------------------------------------------------- stk.mk 612d393b5016ef077f7dad334b03ca6fdb915bce # Version: Commits on Nov 21, 2025 ---------------------------------------------------------------------------------- Significantly improve page up/down handling in lobby chat - add a handlePaging function to allow screens to have custom handling for paging input ; it's only called when a list is not the active widget - Greatly simplify the code in NetworkingLobby by removing key input detection and duplicated code between page up and page down handling. We can simply rely on handlePaging being called. - Remove any condition on focused widgets : the only use of page up and page down in the networking lobby is for chat scrolling, therefore it is always interpreted that way. This makes it more convenient as there is no need to manually select the chatbox first to make paging inputs register. - Make paging move the scroll position by almost a full page (90% of visible height instead of 10%). Paging is not supposed to produce tiny movements., --------------------------------------------------------------------------------------- mangohud.mk f60524b9d31261f6ffdc57cd27687f3b76d64301 # Version: Commits on Nov 21, 2025 --------------------------------------------------------------------------------------- inject_glx: change swapbuffer debug to trace, ---------------------------------------------------------------------------------------- retroarch.mk e2250b716260376b242b9becd5067a80f9217a26 # Version: Commits on Nov 21, 2025 ---------------------------------------------------------------------------------------- ios: fix external keyboards fixes #18426, ---------------------------------------------------------------------------------------- doomretro.mk 26b5ea1c4150fe681026b0b93d80115eb9340da1 # Version: Commits on Nov 21, 2025 ---------------------------------------------------------------------------------------- Don't allow shift key to open menu from title screen, ---------------------------------------------------------------------------------- trx.mk 3626ff4fb11547c2e486a9bc13396bc800736011 # Version: Commits on Nov 21, 2025 ---------------------------------------------------------------------------------- docs: update install trees, -------------------------------------------------------------------------------------------- libretro-dice.mk a72a2c512ed8641c61fa515be6051b06355f0f72 # Version: Commits on Nov 21, 2025 -------------------------------------------------------------------------------------------- Fetch translations & Recreate libretro_core_options_intl.h, ----------------------------------------------------------------------------------------------- libretro-flycast.mk 5bce763f66d77831604cded71b4435f141fa9f54 # Version: Commits on Nov 21, 2025 ----------------------------------------------------------------------------------------------- Merge remote-tracking branch 'origin/dev', ----------------------------------------------------------------------------------------------- libretro-scummvm.mk 99e769b8077fe3f88596657f54fc06d7ba1c3713 # Version: Commits on Nov 21, 2025 ----------------------------------------------------------------------------------------------- ALCACHOFA: Fix room transitions when examining items, -------------------------------------------------------------------------------------------- slang-shaders.mk a2ac00bcd5a44982ecaa6ba6e5b8cc9a9608b1d6 # Version: Commits on Nov 21, 2025 -------------------------------------------------------------------------------------------- Update crt-sines.slang (#812),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Use
std::lock_guardinstead oflockandunlock.Rationale behind Changes
Refactoring to improve code quality.
Suggested Testing Steps
Should not be necessary.
Did you use AI to help find, test, or implement this issue or feature?
No.