Implemented new setting to order source quality settings#306
Open
jakecausier wants to merge 4 commits intoOvenMediaLabs:masterfrom
Open
Implemented new setting to order source quality settings#306jakecausier wants to merge 4 commits intoOvenMediaLabs:masterfrom
jakecausier wants to merge 4 commits intoOvenMediaLabs:masterfrom
Conversation
Member
|
@jakecausier Hi! I am very sorry for the late review. It's a very nice feature. But I reviewed it too late, so this commit is way behind master. If it's okay, please close this pull request and make your request again. If you have any other opinions, please leave a comment. Thank you very much for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've implemented a new setting for the player to use called sourcesOrder, which can organise the quality levels provided by a source either by bitrate, video width, video height, or by custom ordering with the label provided by the encoder.
The value can be provided as a string, object, or array. Some examples below:
Order by labels:
Order by Bitrate, ascending:
Order by video width, descending:
This fixes an issue submitted to the OvenMediaEngine repo:
OvenMediaLabs/OvenMediaEngine#863
Feel free to give suggestions or improvements as this is my first PR to the repo, I've done my best to keep it to the same style of code already written.