Skip to content

Add StartDrawing/FinishDrawing back #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lipsanen merged 1 commit into from
Feb 26, 2026
Merged

Add StartDrawing/FinishDrawing back #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions patterns_archive.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,23 +236,4 @@ namespace patterns
/****************************** DATACACHE ******************************/

PATTERNS(CMDLCache__BeginMapLoad, "BMS-0.9", "55 8B EC 83 EC 08 53 56 8B F1 57 89 75");

/****************************** VGUIMATSURFACE ******************************/

PATTERNS(
CMatSystemSurface__StartDrawing,
"5135",
"55 8B EC 83 E4 C0 83 EC 38 80 ?? ?? ?? ?? ?? ?? 56 57 8B F9 75 57 8B ?? ?? ?? ?? ?? C6 ?? ?? ?? ?? ?? ?? FF ?? 8B 10 6A 00 8B C8 8B 42 20",
"7462488",
"55 8B EC 64 A1 ?? ?? ?? ?? 6A FF 68 ?? ?? ?? ?? 50 64 89 25 ?? ?? ?? ?? 83 EC 14",
"BMS-Retail-0.9",
"55 8B EC 6A FF 68 ?? ?? ?? ?? 64 A1 ?? ?? ?? ?? 50 83 EC 14 56 57 A1 ?? ?? ?? ?? 33 C5 50 8D 45 F4 64 A3 ?? ?? ?? ?? 8B F9 80 3D ?? ?? ?? ?? 00");
PATTERNS(
CMatSystemSurface__FinishDrawing,
"5135",
"56 6A 00 E8 ?? ?? ?? ?? 8B ?? ?? ?? ?? ?? 8B 01 8B ?? ?? ?? ?? ?? 83 C4 04 FF D2 8B F0 85 F6 74 09 8B 06 8B 50 08 8B CE FF D2",
"7462488",
"55 8B EC 6A FF 68 ?? ?? ?? ?? 64 A1 ?? ?? ?? ?? 50 64 89 25 ?? ?? ?? ?? 51 56 6A 00",
"BMS-Retail-0.9",
"55 8B EC 6A FF 68 ?? ?? ?? ?? 64 A1 ?? ?? ?? ?? 50 51 56 A1 ?? ?? ?? ?? 33 C5 50 8D 45 ?? 64 A3 ?? ?? ?? ?? 6A 00");
} // namespace patterns
32 changes: 31 additions & 1 deletion spt/features/hud.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,11 +398,28 @@ namespace patterns
"55 8B EC 83 EC 2C 53 8B D9 8B 0D ?? ?? ?? ?? 56",
"4044",
"6A FF 68 ?? ?? ?? ?? 64 A1 ?? ?? ?? ?? 50 64 89 25 ?? ?? ?? ?? 83 EC 1C 56 6A 04");

PATTERNS(
CMatSystemSurface__StartDrawing,
"5135",
"55 8B EC 83 E4 C0 83 EC 38 80 ?? ?? ?? ?? ?? ?? 56 57 8B F9 75 57 8B ?? ?? ?? ?? ?? C6 ?? ?? ?? ?? ?? ?? FF ?? 8B 10 6A 00 8B C8 8B 42 20",
"7462488",
"55 8B EC 64 A1 ?? ?? ?? ?? 6A FF 68 ?? ?? ?? ?? 50 64 89 25 ?? ?? ?? ?? 83 EC 14",
"BMS-Retail-0.9",
"55 8B EC 6A FF 68 ?? ?? ?? ?? 64 A1 ?? ?? ?? ?? 50 83 EC 14 56 57 A1 ?? ?? ?? ?? 33 C5 50 8D 45 F4 64 A3 ?? ?? ?? ?? 8B F9 80 3D ?? ?? ?? ?? 00");
PATTERNS(
CMatSystemSurface__FinishDrawing,
"5135",
"56 6A 00 E8 ?? ?? ?? ?? 8B ?? ?? ?? ?? ?? 8B 01 8B ?? ?? ?? ?? ?? 83 C4 04 FF D2 8B F0 85 F6 74 09 8B 06 8B 50 08 8B CE FF D2",
"7462488",
"55 8B EC 6A FF 68 ?? ?? ?? ?? 64 A1 ?? ?? ?? ?? 50 64 89 25 ?? ?? ?? ?? 51 56 6A 00",
"BMS-Retail-0.9",
"55 8B EC 6A FF 68 ?? ?? ?? ?? 64 A1 ?? ?? ?? ?? 50 51 56 A1 ?? ?? ?? ?? 33 C5 50 8D 45 ?? 64 A3 ?? ?? ?? ?? 6A 00");
} // namespace patterns

void HUDFeature::InitHooks()
{
FIND_PATTERN(vguimatsurface, CMatSystemSurface__StartDrawing);
FIND_PATTERN(vguimatsurface, CMatSystemSurface__FinishDrawing);
HOOK_FUNCTION(engine, CEngineVGui__Paint);
}

Expand Down Expand Up @@ -509,6 +526,13 @@ void HUDFeature::LoadFeature()
cl_showfps = g_pCVar->FindVar("cl_showfps");
bool result = spt_hud_feat.AddHudDefaultGroup(
HudCallback(std::bind(&HUDFeature::DrawDefaultHUD, this), []() { return y_spt_hud.GetBool(); }, false));

if (ORIG_CMatSystemSurface__StartDrawing && ORIG_CMatSystemSurface__FinishDrawing)
{
// These two functions are optional. HUD looks better with them, but it can work without them too (just with some visual glitches).
foundDrawingFuncs = true;
}

if (result)
{
InitConcommandBase(y_spt_hud);
Expand Down Expand Up @@ -566,6 +590,9 @@ void HUDFeature::DrawDefaultHUD()

void HUDFeature::DrawHUD(bool overlay)
{
if (foundDrawingFuncs)
ORIG_CMatSystemSurface__StartDrawing(interfaces::mat_system_surface);

try
{
// Draw default callbacks
Expand Down Expand Up @@ -630,6 +657,9 @@ void HUDFeature::DrawHUD(bool overlay)
{
Msg("Error drawing HUD: %s\n", e.what());
}

if (foundDrawingFuncs)
ORIG_CMatSystemSurface__FinishDrawing(interfaces::mat_system_surface);
}

IMPL_HOOK_THISCALL(HUDFeature, void, CEngineVGui__Paint, void*, PaintMode_t mode)
Expand Down
5 changes: 5 additions & 0 deletions spt/features/hud.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,12 @@ class HUDFeature : public FeatureWrapper<HUDFeature>
ConVar* cl_showpos = nullptr;
ConVar* cl_showfps = nullptr;

// If we found both StartDrawing and FinishDrawing
bool foundDrawingFuncs = false;

DECL_HOOK_THISCALL(void, CEngineVGui__Paint, void*, PaintMode_t mode);
DECL_MEMBER_THISCALL(void, CMatSystemSurface__StartDrawing, void*);
DECL_MEMBER_THISCALL(void, CMatSystemSurface__FinishDrawing, void*);

void DrawHUD(bool overlay);
void DrawDefaultHUD();
Expand Down