Skip to content

[#594] Adjust typography modifier to be coform with line height token by adding line spacing and paddings #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

[#594] Adjust typography modifier to be coform with line height token by adding line spacing and paddings #688

wants to merge 5 commits into from

Conversation

@ludovic35
Copy link
Member

@ludovic35 ludovic35 commented May 28, 2025

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#594

Description

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • Design review has been done
  • Accessibility review has been done
  • Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues
  • The wiki has been updated if needed (optional)

@ludovic35 ludovic35 linked an issue May 28, 2025 that may be closed by this pull request
[Bug] Typography interline is wrong #594
Open
1 task
@ludovic35 ludovic35 mentioned this pull request May 28, 2025
Draft
@ludovic35 ludovic35 force-pushed the 594-bug-typography-interline-is-wrong branch from b08d679 to f75e0c2 Compare June 2, 2025 07:40
@pylapp pylapp force-pushed the develop branch 3 times, most recently from 5e985c6 to eddd742 Compare June 12, 2025 17:01
@pylapp pylapp force-pushed the develop branch 3 times, most recently from 47ccd0d to 17cf257 Compare August 26, 2025 20:51
@pylapp pylapp force-pushed the develop branch 11 times, most recently from 4439362 to 0f671d4 Compare September 2, 2025 10:28
@pylapp pylapp force-pushed the develop branch 2 times, most recently from 359407c to 6fa9080 Compare October 6, 2025 11:17
@pylapp pylapp force-pushed the develop branch 4 times, most recently from 61fb35f to 56b76ff Compare November 3, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pylapp pylapp Awaiting requested review from pylapp pylapp will be requested when the pull request is marked ready for review pylapp is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Typography interline is wrong

1 participant

@ludovic35