Skip to content

Version 3#13

Merged
JohnMThayer merged 2 commits into
mainfrom
version-3
May 21, 2025
Merged

Version 3#13
JohnMThayer merged 2 commits into
mainfrom
version-3

Conversation

@JohnMThayer
Copy link
Copy Markdown
Contributor

@JohnMThayer JohnMThayer commented May 21, 2025

Proposed changes

This is a breaking Version 3 change.

Included are:

  • eliminate JSON rendering, which was problematic (not in lane)
  • flush out ConfigMaps design to be called References
  • eliminate the process() method, which grew to be unnecessary as the engine evolved
  • results from getResults() used to be a TreeSet, which in Java is problematic; now results from generateResults() is a TreeMap, which in Java allows getting by key.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation only

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@JohnMThayer JohnMThayer merged commit fbceea9 into main May 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant