ref: rename VMContext::curent() -> VM::context()#91
Merged
qalisander merged 8 commits intomainfrom Apr 8, 2025
Merged
Conversation
qalisander
commented
Apr 4, 2025
| assert_eq!(block::chainid(), DEFAULT_CHAIN_ID); | ||
|
|
||
| VMContext::current().set_chain_id(ETHEREUM_SEPOLIA_CHAIN_ID); | ||
| VM::context().set_chain_id(ETHEREUM_SEPOLIA_CHAIN_ID); |
Member
Author
There was a problem hiding this comment.
That is actually all this refactoring about. Make this invocation shorter, until we don't have that many config functions public. And this breaking change will not have much impact.
I remember @0xNeshi supported this idea before.
qalisander
requested review from
0xNeshi,
bidzyyys and
ggonzalez94
as code owners
0xNeshi
reviewed
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist