Merged
Conversation
# Conflicts: # Cargo.lock # Cargo.toml # crates/motsu/src/context.rs # crates/motsu/src/router.rs
Member
|
So tests work. But now we have many deprecated clippy complains and I don't like the new api for contract call |
qalisander
requested review from
0xNeshi,
ggonzalez94 and
qalisander
as code owners
bidzyyys
commented
Feb 24, 2025
Collaborator
Author
bidzyyys
left a comment
bidzyyys
left a comment
There was a problem hiding this comment.
@qalisander? Where do we have those errors you mentioned?
Collaborator
Author
There was a problem hiding this comment.
Why do we need to add these shims?
Member
There was a problem hiding this comment.
It fails to compile otherwise. With the new stylus-sdk release it requires all missing shims to be linked. It should be temporary until we implement Host trait
Collaborator
There was a problem hiding this comment.
We can merge the PR as-is as a temp. solution, and fix warnings as part of the same PR in which the Host trait is implemented. This way the second (focused) PR will be a bit easier to review
Member
3 tasks
# Conflicts: # crates/motsu/src/lib.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #45
PR Checklist