Add AdminCap-driven AMM config update flow#62
Closed
CoveMB wants to merge 6 commits intosplit/25-ammconfig-modulefrom
Closed
Add AdminCap-driven AMM config update flow#62CoveMB wants to merge 6 commits intosplit/25-ammconfig-modulefrom
CoveMB wants to merge 6 commits intosplit/25-ammconfig-modulefrom
Conversation
CoveMB
requested review from
bidzyyys,
ericnordelo and
immrsd
as code owners
Contributor
|
Blocked by #61 |
bidzyyys
reviewed
Mar 11, 2026
Contributor
There was a problem hiding this comment.
We do not want to use "dummy" contracts for testing. We should use the existing ones.
| expect(output.ammConfigId).toBe(ammConfigId) | ||
| expect(output.adminCapId).toBe(adminCapId) | ||
| expect(output.ammConfig.configId).toBe(ammConfigId) | ||
| expect(output.ammConfig.baseSpreadBps).toBe("55") |
Contributor
There was a problem hiding this comment.
@CoveMB, in general when you set some value in test, like baseSpreadBps: "55", and then you perform a check against that updated value expect(output.ammConfig.baseSpreadBps).toBe("55") ; it is much easier to assign at first that value to some variable and use the variable. It is much better for maintenance and refactoring.
Contributor
|
Replaced with #81. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26
Summary
Adds the AdminCap-managed AMM update script flow.
Scope
amm-updatescriptNotes
Admin capability resolution primitives are already available from the AMM domain layer in the prior stack PR.