Skip to content

Conversation

@PivasDesant
Copy link

Fixed a couple of places in tokens.adoc where we were saying "Ethereum" when we should have been saying "EVM-compatible".

The docs were making it sound like this library only works on Ethereum, but it actually works on all EVM chains - Polygon, Arbitrum, Base, you name it. I noticed this while working on something else and figured it was worth fixing since it could confuse devs building on other chains.

Changed:

  • "Ethereum smart contract" → "EVM-compatible smart contract"
  • "everything in Ethereum" → "everything in EVM-compatible blockchains"

This keeps things consistent with the rest of the docs where we already use "EVM" for stuff that applies to all chains.

@PivasDesant PivasDesant requested a review from a team as a code owner December 10, 2025 19:15
@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2025

⚠️ No Changeset found

Latest commit: 7e41e33

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2025

Walkthrough

This pull request updates the tokens documentation to broaden its scope from Ethereum-specific references to EVM-compatible blockchains. The changes replace specific Ethereum mentions with more general EVM-compatible terminology in the token contract description and Standards section. These are documentation-only modifications with no changes to exported or public code declarations, logic, or behavior.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and clearly describes the main change: replacing Ethereum-specific terminology with EVM-compatible wording in the tokens.adoc file, which matches the actual changes made.
Description check ✅ Passed The description is relevant and informative, explaining the rationale for the changes (clarifying cross-chain compatibility), providing specific examples of what was changed, and noting alignment with existing documentation practices.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 53c2c64 and 7e41e33.

📒 Files selected for processing (1)
  • docs/modules/ROOT/pages/tokens.adoc (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: coverage
  • GitHub Check: slither
  • GitHub Check: tests-upgradeable
  • GitHub Check: tests-foundry
  • GitHub Check: tests
  • GitHub Check: halmos
🔇 Additional comments (1)
docs/modules/ROOT/pages/tokens.adoc (1)

12-12: Terminology updates clarify EVM-wide applicability.

The changes accurately broaden the scope from Ethereum-specific to EVM-compatible terminology. Line 12 correctly describes how smart contracts, methods, and mappings work across all EVM chains, not just Ethereum. Line 25 properly reflects that token standards and interoperability patterns apply to the entire EVM ecosystem.

The retention of "Ether" as a fungible-asset example (line 19) remains contextually appropriate and does not conflict with the broader EVM-compatible framing.

Also applies to: 25-25


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant