Skip to content

Conversation

@ernestognw
Copy link
Member

Add clarification about how signatures are parsed depending on the length of the bytes buffer.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@ernestognw ernestognw requested a review from a team as a code owner October 13, 2025 14:51
@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2025

⚠️ No Changeset found

Latest commit: a2ac26e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ernestognw ernestognw changed the title Clarify how ECDSA parse signatures are used Clarify how ECDSA signatures are parsed Oct 13, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 13, 2025

Walkthrough

Documentation in contracts/utils/cryptography/ECDSA.sol was expanded to clarify signature parsing behavior. It now specifies handling differences between 64-byte and 65-byte signatures, including normalization of v for 64-byte signatures and the expectation that v is 27 or 28 for 65-byte signatures. It also advises validating inputs or using tryRecover/recover. No implementation, control flow, or functional behavior was modified. No changes were made to exported or public declarations.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly and accurately describes the primary change, which is adding clarification to how ECDSA signatures are parsed, and it is both specific and concise without extraneous details.
Description Check ✅ Passed The description directly references the documentation update for parsing signatures by buffer length, matching the change set and remaining on topic with the added clarifications.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 78eb160 and a2ac26e.

📒 Files selected for processing (1)
  • contracts/utils/cryptography/ECDSA.sol (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: Redirect rules - solidity-contracts
  • GitHub Check: tests-foundry
  • GitHub Check: slither
  • GitHub Check: tests-upgradeable
  • GitHub Check: tests
  • GitHub Check: coverage
  • GitHub Check: Header rules - solidity-contracts
  • GitHub Check: halmos
  • GitHub Check: Pages changed - solidity-contracts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Amxx Amxx added this to the 5.5-final milestone Oct 13, 2025
@Amxx Amxx merged commit 1cf1377 into OpenZeppelin:master Oct 13, 2025
22 of 23 checks passed
Amxx pushed a commit that referenced this pull request Oct 13, 2025
@Amxx
Copy link
Collaborator

Amxx commented Oct 13, 2025

cherry picked on release-v5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants