-
Notifications
You must be signed in to change notification settings - Fork 12.4k
Typos and other minor fixes (group n°5) #5959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
119 commits
Select commit
Hold shift + click to select a range
a1aa81b
fix: incorrect documentation reference in ERC4626Fees._withdraw (#5955)
strmfos a6a8dfc
Merge branch 'master' into typo-fixes
Amxx 0571375
Update CHANGELOG.md (#5969)
mdfaizanaquil 27703a5
Merge branch 'master' into typo-fixes
Amxx 835748a
Escape dots in regex for solidity pragma version matching (#5981)
sashaodessa 7a4a7fe
fix ranges in isValidERC1271SignatureNow documentation
Amxx 5004def
chore: fix misuses of 'a' vs 'an' (#5988)
dulanting 7931f44
Merge branch 'master' into typo-fixes
ernestognw 5e69660
Lint
ernestognw 067f190
docs: fix minor grammar and phrasing issues in documentation (#5999)
prestoalvarez dc53fdf
docs: improvement of grammar (#6006)
CreeptoGengar 785974f
docs: add comment explaining execution delay value in AccessManaged t…
forkfury ec0ec42
docs(ERC2771Forwarder): fix validate signer reference and clarify imp…
radik878 7293c72
docs: add security warnings for AccessManager migration (#6016)
Lil-Duckling-22 70493d3
Merge branch 'master' into typo-fixes
ernestognw 83ead03
chore: fix 4626 error documentations (#6026)
kevzzsk 95644ff
Merge branch 'master' into typo-fixes
ernestognw 9cfcf43
docs: correct TimelockController role names in access control guide (…
DeVikingMark 82e0a59
docs(erc721): fix _setTokenURI xref to ERC721URIStorage (#6028)
VolodymyrBg bf196f6
fix: ERC2771Forwarder _validate doc comment (#6029)
sashass1315 804307a
refactor(ERC20FlashMint): remove unused parameter suppression in _fla…
sashaodessa 599e66b
docs: fix P256 example functions to be view instead of pure (#6031)
GarmashAlex f4685fc
Merge branch 'master' into typo-fixes
ernestognw 9c0046f
fix: correct RoleGranted event documentation for existing members (#6…
phrwlk 74703ae
docs(IAccessManager): document locked roles for label/admin/guardian/…
Forostovec 47615e5
docs: use canonical PackedUserOperation field names (#6039)
GarmashAlex 520ade0
docs: clarify 20-byte calldata minimum requirement in ERC2771Context …
avorylli 074795a
docs: improvement of grammar (#6035)
CreeptoGengar 7bdaf34
Drop unused IERC165 import from timelock controller (#6042)
Doryu001 e793343
Merge branch 'master' into typo-fixes
Amxx a4b70a8
Сhore: remove unused imports from Heap library (#6060)
Nixuewyreks 9c103fc
chore: fix broken link (#6058)
Snezhkko d7181c3
docs(governance): fix GovernorCountingSimple import path to extension…
MozirDmitriy de87771
docs: add setup() to CircularBuffer example to show required initiali…
Galoretka 2518fbd
Remove ERC7702 mentions in favor of EIP7702 (#6044)
ernestognw 808a851
Merge branch 'master' into typo-fixes
ernestognw 7b71c14
docs: fix incomplete sentence in EOA delegation guide (#6066)
DeVikingMark e1b7411
docs: fix WebAuthn cross-reference to verify in ERC7913WebAuthnVerifi…
VolodymyrBg 668d3b5
Merge branch 'master' into typo-fixes
Amxx a60b367
fix: correct LowLevelCall overload reference (#6071)
reallesee 2f1386c
docs(Heap): clarify priority via comparator and default min-heap beha…
Forostovec f48c229
Remove dead abstract contract Impl from DummyImplementation mock (#6073)
sashass1315 c906400
Drop redundant await in GovernorNoncesKeyed helper (#6064)
Doryu001 b3570cb
Use strict equality in Arrays test helpers (#6086)
prestoalvarez 83fc81a
docs: improvement of grammar (#6085)
CreeptoGengar 2449027
docs: fix misleading in ERC721Enumerable._increaseBalance (#6087)
aso20455 7686518
Merge branch 'master' into typo-fixes
Amxx 9fe0e62
Fix incorrect reference in _withdraw documentation (#6090)
Fallengirl b2c5e02
fix: ClashingImplementation comment to reference upgradeToAndCall (#6…
radik878 a8de514
docs: fix function reference in LowLevelCall (#6089)
eeemmmmmm fc8824d
Merge branch 'master' into typo-fixes
ernestognw 8a480da
docs: update miner terminology to block proposer for PoS compatibilit…
DeVikingMark 0fffeaf
fix: typos in ERC7739Utils comments (#6102)
Bashmunta df13d17
docs(ERC4626Fees): fix internal links to ERC4626 deposit/_withdraw (#…
Fibonacci747 598b88b
docs: document TimelockController CANCELLER_ROLE in governance guide …
Forostovec fe75ac0
Adjust `MAX_UINT32` and `MAX_UINT48` constants in Time.test.js (#6095)
aso20455 a172897
fix: IERC7579Execution docs to reference ERC7579Utils (#6097)
radik878 1e5c610
test: fix incorrect value in Heap test comments (#6099)
dizer-ti ec3e80e
docs: improvement of grammar (#6110)
CreeptoGengar ea71000
fix: typos in ERC1155 extension (#6113)
GarmashAlex 88dedb7
Merge branch 'master' into typo-fixes
ernestognw 8ff1a7e
fix(test): import chai expect in governance helper for fail path (#6138)
GarmashAlex 0118d1e
Fix typo in upgradeable version of README (#5987)
Amxx 7e295f6
fix(test): use this.value instead of undefined this.amount (#6131)
Forostovec 512070b
fix(docs): add EIP712 to multisig example contracts’ inheritance (#6127)
radik878 ecb93c1
Fix optimizer configuration in foundry.toml (#6117)
maradini77 cd99b2e
fix(docs): correct ERC-1155 on-chain metadata guidance (#6111)
DeVikingMark 1d78585
fix: sync ERC20FlashMint with implementation (#6083)
zeroprooff 20aed20
Merge branch 'master' into typo-fixes
Amxx 836a8b5
fix: correct comment to reference setGrantDelay (#6144)
ANtutov a0f4eaa
Merge branch 'master' into typo-fixes
Amxx 50a1d0f
docs: fix incorrect Base64.decode NatSpec (#6148)
dizer-ti 56ee90b
fix: add missing space in NatSpec comment (#6147)
zeroprooff cb49220
docs(interfaces): add IERC1967, IERC2309 to standardized interface li…
Forostovec 31f9029
Merge branch 'master' into typo-fixes
Amxx 6969f42
fix: correct backtick formatting in ECDSA recover function natspec (#…
denevertt c2ae6af
chore: fix typos (#6149)
Fibonacci747 45df31c
chore: fix typos (#6108)
MozirDmitriy a9ad11a
docs(fv): update README to .conf-based specs and correct run syntax (…
sashass1315 092d342
chore: fix typos (#6157)
ninastef 1b3ba2e
fix: correct comment typo in getAccessChangeCall rule (#6109)
hawkadrian 60f9c45
Update `MerkleProof` template
arr00 ac2f417
docs: fix NatSpec comment format (#6161)
zeroprooff 2ae3a0c
fix: correct log2() lookup table comment to MSB-first half (#6158)
GarmashAlex 106f9fd
Merge branch 'master' into typo-fixes
Amxx 9770fd1
Merge branch 'master' into typo-fixes
Amxx 5254d9d
Fix incorrect preposition in inheritance documentation (#6168)
anim001k d71e289
Merge branch 'master' into typo-fixes
Amxx 8edd671
docs(ecdsa): clarify ECDSAInvalidSignature describes general invalid …
Bashmunta 0e3260e
docs: fix typo (#6176)
letmehateu 8591fa0
docs(accounts): fix AbstractSigner xrefs to utils/cryptography.adoc (…
VolodymyrBg 9b1585a
Merge branch 'master' into typo-fixes
Amxx 27c21b4
docs:fix grammar minor typo (#6177)
bobtajson fd858ba
fix broken test
arr00 8760746
docs: fix duplicate argument in P256 usage examples (#6185)
aso20455 bb51d52
Merge branch 'master' into typo-fixes
Amxx fa25516
docs: fixes minor typo (#6193)
bobtajson 36cf640
Merge branch 'master' into typo-fixes
ernestognw d2ae1d0
docs: fix beginDefaultAdminTransfer emitted event name (#6194)
yyhrnk 59af6bb
Update CHANGELOG.md
arr00 2fd9903
fix list
arr00 0c8f95b
add missing interfaces to api ref
arr00 1d6856f
fix docs generation
arr00 47ebf1b
Update contracts/governance/README.adoc
arr00 6e56440
add missing interfaces to docs
arr00 9b013eb
clarify 1155 supply comment
arr00 845c313
Update contracts/utils/LowLevelCall.sol
arr00 35e21c3
Update contracts/utils/LowLevelCall.sol
arr00 4c7b787
update docs in
arr00 4972c9b
Update contracts/access/manager/IAccessManager.sol
Amxx 55fdc90
Update contracts/access/manager/IAccessManager.sol
Amxx f816f8a
Update contracts/token/ERC20/extensions/ERC20FlashMint.sol
Amxx e7bd453
Update docs/modules/ROOT/pages/accounts.adoc
Amxx 49e7489
Update governance.js
Amxx fecaa6e
Update test/access/manager/AccessManaged.test.js
Amxx 1c0ad03
improve doc in `governance.adoc`
arr00 c8c78f7
fix `CircularBuffer` list
arr00 5e87d4a
fix lnk in accounts docs
arr00 b887908
update utils docs
arr00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No point in having this. Doesn't show up in docs.