Migrate WebAuthn library, signer and verifier from community #5809
+873
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f1101d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Amxx
commented
Jul 22, 2025
Amxx
commented
Jul 22, 2025
| _validateChallenge(auth.clientDataJSON, auth.challengeIndex, challenge) && // 12 | ||
| _validateUserPresentBitSet(auth.authenticatorData[32]) && // 16 | ||
| (!requireUV || _validateUserVerifiedBitSet(auth.authenticatorData[32])) && // 17 | ||
| _validateBackupEligibilityAndState(auth.authenticatorData[32]) && // Consistency check |
Collaborator
Author
There was a problem hiding this comment.
TODO:
Do we want to completelly remove that check ? It could be argued that the WebAuthn devices should perfom that check offchain, and that we should not deal with it.
ernestognw
reviewed
Jul 23, 2025
ernestognw
previously approved these changes
Jul 23, 2025
Amxx
commented
Jul 23, 2025
ernestognw
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
npx changeset add)