ERC20Bridgable (ERC-7802) #5735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 19fc7ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ernestognw
reviewed
Jun 11, 2025
ernestognw
previously approved these changes
Jun 11, 2025
arr00
reviewed
Jun 11, 2025
Comment on lines
+6
to
+12
| /// @title IERC7802 | ||
| /// @notice Defines the interface for crosschain ERC20 transfers. | ||
| interface IERC7802 is IERC165 { | ||
| /// @notice Emitted when a crosschain transfer mints tokens. | ||
| /// @param to Address of the account tokens are being minted for. | ||
| /// @param amount Amount of tokens minted. | ||
| /// @param sender Address of the caller (msg.sender) who invoked crosschainMint. |
Contributor
There was a problem hiding this comment.
Lots of non-dev tags here--won't be parsed for documentation.
Member
There was a problem hiding this comment.
Yes, it's true we have been not too strict with that for interfaces and we try to keep them as defined in their corresponding ERCs (which was the case for 7802 as far as I remember). I would be in favor of rendering @param and @returns in the interfaces page only.
arr00
reviewed
Jun 11, 2025
Co-authored-by: Arr00 <[email protected]>
ernestognw
previously approved these changes
Jun 11, 2025
ernestognw
previously approved these changes
Jun 11, 2025
arr00
reviewed
Jun 11, 2025
arr00
reviewed
Jun 11, 2025
arr00
approved these changes
Jun 11, 2025
ernestognw
approved these changes
Jun 12, 2025
Amxx
added a commit
to Amxx/openzeppelin-contracts
that referenced
this pull request
Jun 12, 2025
Co-authored-by: ernestognw <[email protected]> Co-authored-by: Arr00 <[email protected]> Signed-off-by: Hadrien Croubois <[email protected]>
Amxx
added a commit
that referenced
this pull request
Jun 12, 2025
Signed-off-by: Hadrien Croubois <[email protected]> Co-authored-by: ernestognw <[email protected]> Co-authored-by: Arr00 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5734
Do we want to cherrypick that on 5.4 ? Is it still possible to get it audited in time ?
PR Checklist
npx changeset add)