-
Notifications
You must be signed in to change notification settings - Fork 12.3k
Increase SignatureChecker minimum pragma to 0.8.24 #5716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase SignatureChecker minimum pragma to 0.8.24 #5716
Conversation
|
|
My understanding is:
If this is all correct, then I approve. |
Amxx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really wondering how much of a breaking change it is. I know @ernestognw wants to move forward with small things like that. I also don't think its a major issue at all ... but it might technically break projects that use Governor (or just SignatureChecker) and have pinned a version of the compiler >=0.8.20, <0.8.24.
Maybe we want to add a "breaking change" entry to the Changelog saying that some contract compiler requirement have evolved, and that users may need to upgrade the compiler version they are using.
Yes, this is correct. Basically moving 7913Utils to SIgnatureChecker forced this pragma increase.
Also true, I added a small note I think should be good enough |
Fixes #????
PR Checklist
npx changeset add)