Skip to content

Conversation

@voronor
Copy link
Contributor

@voronor voronor commented Dec 23, 2024

Description

While reviewing the code, I noticed a minor inaccuracy in the comment for the callGasLimit function within the ERC4337Utils library. The current comment states that the function returns accountGasLimits, which is incorrect. The function actually returns callGasLimit.

I’ve updated the comment to correctly describe the function’s behavior. Here’s the corrected comment:

/// @dev Returns `callGasLimit` from the {PackedUserOperation}.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2024

⚠️ No Changeset found

Latest commit: 2b88e7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@voronor voronor requested a review from arr00 December 23, 2024 17:44
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @voronor

@ernestognw ernestognw merged commit c3b3ae7 into OpenZeppelin:master Dec 23, 2024
20 of 21 checks passed
@gitpoap-bot
Copy link

gitpoap-bot bot commented Dec 23, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 OpenZeppelin Contracts Contributor:

GitPOAP: 2024 OpenZeppelin Contracts Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Amxx pushed a commit to Amxx/openzeppelin-contracts that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants