-
Notifications
You must be signed in to change notification settings - Fork 12.3k
Add Governor module connecting with AccessManager #4523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
frangio
merged 36 commits into
OpenZeppelin:feat/access-manager
from
frangio:governor-timelock-access
Aug 16, 2023
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
5fd9a98
add back GovernorTimelock
frangio 1498539
WIP
frangio 36dc884
rename GovernorTimelock -> GovernorTimelockAccess
frangio 2d2b087
make base delay modifiable
frangio 221261f
remove available since
frangio 499a2a1
use relay to call the target contract
frangio d5ca8be
fix warning
frangio 7ed7c1c
Update contracts/governance/extensions/GovernorTimelockAccess.sol
frangio bf9fdf9
fix initial set of base delay
frangio 5ced769
rename maxDelay -> neededDelay
frangio 3820637
address guardian cancellation risk
frangio 31e20a1
use single manager per governor
frangio 56ed5a4
add nonces
frangio 6ca99ef
make _hashOperation private
frangio e34c093
add docs for nonce
frangio 40adbb7
typo
frangio 2c41d41
Update contracts/governance/extensions/GovernorTimelockAccess.sol
frangio 1446af0
Update contracts/governance/extensions/GovernorTimelockAccess.sol
frangio bc2bfa5
Update contracts/access/manager/AccessManager.sol
frangio af274b1
add proposalNeedsQueuing
frangio bac912e
remove timepoint from executed and canceled events
frangio a1cbc83
add tests for proposalNeedsQueuing
frangio ebd6dcd
Apply suggestions from code review
frangio 6902ad7
fix docs
frangio e96474c
remove unnecessary override
frangio 452c65e
remove _authorityOverride
frangio f7b3b93
add missing docs
frangio 3b47038
remove unused imports
frangio 8d5e734
typo
frangio 4f89411
lint
frangio 40eea48
add basic tests
frangio 0604f4d
add custom error
frangio 16519fe
lint
frangio 85148a9
make variable private
frangio a36618b
add changeset
frangio b37ed30
do not delete executionPlan
frangio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.