Do not emit Approval event when calling transferFrom #4370
Conversation
🦋 Changeset detectedLatest commit: 19990eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| const expectedSupply = initialSupply.add(amount); | ||
| expect(await this.token.totalSupply()).to.be.bignumber.equal(expectedSupply); | ||
| }); | ||
| const describeBurn = function (description, amount) { |
There was a problem hiding this comment.
For consistency, I'd suggest:
| const describeBurn = function (description, amount) { | |
| function describeBurn (description, amount) { |
Non-blocking.
There was a problem hiding this comment.
That is not related to this PR. Maybe we can put that in a dedicated "cleanup/consistency" PR?
Otherwize we can do it here, I don't have a strong opinion.
There was a problem hiding this comment.
This wasn't introduced in this PR so if we want to change it let's do it separately.
There was a problem hiding this comment.
Agree in doing it in another PR
|
It requires a changeset |
Co-authored-by: Ernesto García <[email protected]>
frangio
left a comment
frangio
left a comment
There was a problem hiding this comment.
Looks good. Minor comment.
Co-authored-by: Francisco <[email protected]>
ernestognw
left a comment
ernestognw
left a comment
There was a problem hiding this comment.
Sorry for just bringing it up but we talked before about registering the changes needed to migrate to 5.0 and I think this should go into this list.
Did we agree to put it in the CHANGELOG?
Co-authored-by: Ernesto García <[email protected]>
|
If there are any breaking changes that users need to adapt in their code when upgrading, we should put them in a section "How to Upgrade from 4.x" in the changelog. In this case though users don't need to do anything, so I don't think there is anything we need to mention in that section, beyond what we should mention in the changeset. |
Co-authored-by: Ernesto García <[email protected]> Co-authored-by: Francisco <[email protected]>
Co-authored-by: Ernesto García <[email protected]> Co-authored-by: Francisco <[email protected]>
3 participants
Fixes LIB-876
PR Checklist
npx changeset add)