Procedurally generate EnumerableSet and EnumerableMap#3429
Merged
Conversation
Contributor
|
Now that we have gas reporting, with this PR it should be easy to compare the cost of our current approach (cast everything to a Bytes32Set) versus duplicating the code for every type. |
Collaborator
Author
|
We discussed that, and casting, while not being a breaking change on the solidity side would not be supported by the upgrades plugin. I would do this PR in 4.X, and then do the change for casting (depending on the gas outcome) in 5.0 |
Contributor
|
I love everything about this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist