Add customizable fee receiver to ERC20FlashMint#3327
Merged
frangio merged 9 commits intoMay 6, 2022
Merged
Conversation
mazenkhalil
changed the title
frangio
reviewed
Apr 7, 2022
Contributor
frangio
left a comment
frangio
left a comment
There was a problem hiding this comment.
This is looking pretty good, thank you. Some minor comments.
frangio
changed the title
…sion-improvement-#3316
frangio
reviewed
Apr 8, 2022
frangio
reviewed
Apr 9, 2022
Amxx
reviewed
Apr 11, 2022
Amxx
reviewed
Apr 11, 2022
| } | ||
|
|
||
| function flashFee(address token, uint256 amount) public view virtual override returns (uint256) { | ||
| super.flashFee(token, amount); |
Collaborator
There was a problem hiding this comment.
This super call is not needed and can be confusing, even if it is just a mock.
Contributor
Author
There was a problem hiding this comment.
The purpose of this super call is to cover the validation defined in the super implementation. I have opened another ticket to fix the flashFee function #3331. Upon that change this super call won't be required anymore.
Amxx
previously requested changes
Apr 11, 2022
Collaborator
Amxx
left a comment
Amxx
left a comment
There was a problem hiding this comment.
Great work overall. There are a few things regarding testing that can be improved.
We also need a Changelog entry before we merge that PR.
frangio
previously approved these changes
Apr 12, 2022
Contributor
frangio
left a comment
frangio
left a comment
There was a problem hiding this comment.
Thank you @mazenkhalil. This looks good.
mazenkhalil
deleted the
fix/erc3156-flash-loans-extension-improvement-#3316
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3316
Allow implementers to set the address for which the flash loan fee amount is transferred to. Instead of burning the loan fee.
PR Checklist