Skip to content

Add AddressToUintMap#3150

Merged
Amxx merged 6 commits into
OpenZeppelin:masterfrom
gaspardip:feature/AddressToUintMap
Feb 1, 2022
Merged

Add AddressToUintMap#3150
Amxx merged 6 commits into
OpenZeppelin:masterfrom
gaspardip:feature/AddressToUintMap

Conversation

@gaspardip
Copy link
Copy Markdown
Contributor

Continuing the work of #3073, this PR adds the new AddressToUintMap map type, which is very useful for storing balances.

I've added tests and a changelog entry.

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@frangio frangio mentioned this pull request Jan 31, 2022
3 tasks
@frangio frangio changed the title feat(EnumerableMap): add AddressToUintMap Add AddressToUintMap Jan 31, 2022
Comment thread contracts/utils/structs/EnumerableMap.sol Outdated
Comment thread contracts/utils/structs/EnumerableMap.sol Outdated
Comment thread CHANGELOG.md
Comment thread contracts/utils/structs/EnumerableMap.sol Outdated
Comment thread test/utils/structs/EnumerableMap/helpers.js Outdated
Comment thread .prettierrc
{
"files": "*.sol",
"options": {
"singleQuote": false,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these changes to .prettierrc ? Can you explain what they do exactly ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint config doesn't match the prettier config for what I've noticed using the vscode prettier extension (although running the package.json lint scripts would give the same result)

@Amxx
Copy link
Copy Markdown
Collaborator

Amxx commented Feb 1, 2022

For the EnumerableSet, we have a single mock file (mocks/EnumerableSetMock.sol) that contains multiple contracts.
I think we should do the same for EnumerableMap

@Amxx Amxx merged commit ca755ce into OpenZeppelin:master Feb 1, 2022
@gaspardip gaspardip deleted the feature/AddressToUintMap branch February 1, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants