fix: await async writes to avoid race conditions in update-scarb-project.ts #639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a potential race condition issue in the
update-scarb-project.tsfiles for both cairo and cairo_alpha packages.Changes
awaittowriteLibCairo()calls in both packagesawaittoupdateScarbToml()calls in both packagesProblem
The
writeLibCairoandupdateScarbTomlfunctions are async but were not being awaited in theupdateScarbProject()function. While Node.js usually keeps the event loop alive, failing to await async operations is brittle and can cause non-deterministic behavior or intermittent exits.Files Changed
packages/core/cairo/src/scripts/update-scarb-project.tspackages/core/cairo_alpha/src/scripts/update-scarb-project.tsTesting
The changes ensure that:
Fixes race conditions and potential intermittent script failures.
Related to: #638 (comment)