Skip to content

Conversation

@ernestognw
Copy link
Member

Description

In some contexts is convenient to change the width of the controls.

Google.Chrome.mp4

Copy link
Member

@ericglau ericglau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a few comments:

  • If you expand the nav almost all of the way to the right:
    1. The "Deploy" button partly gets covered.
    2. If you click "Deploy", the arrows to close the Deploy modal get hidden. This may need some adjusting of the z-indexes, such as here.
Screen.Recording.2025-05-30.at.6.03.21.PM.mov
  • The space between expand/collapse arrows and the question mark isn't constant.
Screen.Recording.2025-05-30.at.6.08.02.PM.mov
  • Can you apply this change to the other languages under packages/ui/src/*/App.svelte?

@ernestognw
Copy link
Member Author

Thanks for reviewing @ericglau!

If you expand the nav almost all of the way to the right

Right! I didn't consider much of the potential UI issues on the borders. I also think it makes sense to restrict to a minimum width. So I set it to min-w-72 and for the maximum I took the fixed width of the Defender sidebar (360px) plus roughly 40 px for the close button (It's weird to measure, it's kinda floating).

The constrained sizes should make it better now

The space between expand/collapse arrows and the question mark isn't constant.

Also pretty good catch! I adjusted and removed an unused align property in the HelpTooltip component. Should be fine now

Can you apply this change to the other languages under packages/ui/src/*/App.svelte?

Done!

@ernestognw ernestognw requested a review from ericglau May 30, 2025 22:37
Copy link
Member

@ericglau ericglau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ericglau ericglau requested a review from CoveMB June 2, 2025 21:09
@ernestognw ernestognw enabled auto-merge (squash) June 2, 2025 21:10
Copy link
Contributor

@CoveMB CoveMB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good thanks ✨
I am wondering if maybe it would make sense to display the resizing arrow ↔ all along the left border of the settings?

@ernestognw ernestognw merged commit 1dc33d9 into master Jun 5, 2025
21 checks passed
@ernestognw ernestognw deleted the chore/resize-controls branch June 5, 2025 19:26
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants