-
Notifications
You must be signed in to change notification settings - Fork 187
Allow resizing controls #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just a few comments:
- If you expand the nav almost all of the way to the right:
- The "Deploy" button partly gets covered.
- If you click "Deploy", the arrows to close the Deploy modal get hidden. This may need some adjusting of the z-indexes, such as here.
Screen.Recording.2025-05-30.at.6.03.21.PM.mov
- The space between expand/collapse arrows and the question mark isn't constant.
Screen.Recording.2025-05-30.at.6.08.02.PM.mov
- Can you apply this change to the other languages under
packages/ui/src/*/App.svelte?
|
Thanks for reviewing @ericglau!
Right! I didn't consider much of the potential UI issues on the borders. I also think it makes sense to restrict to a minimum width. So I set it to The constrained sizes should make it better now
Also pretty good catch! I adjusted and removed an unused
Done! |
ericglau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
CoveMB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good thanks ✨
I am wondering if maybe it would make sense to display the resizing arrow ↔ all along the left border of the settings?
Description
In some contexts is convenient to change the width of the controls.
Google.Chrome.mp4