Skip to content

Conversation

@CoveMB
Copy link
Contributor

@CoveMB CoveMB commented May 26, 2025

Fixes #440 (for Cairo and Cairo-alpha only)

  • Add input UI component to capture security info
  • Update info type for Cairo
  • Add security info for AI agent
  • Add contract documentation for Cairo contract builder
  • Add print of contract documentation ( here security info) for Cairo
  • Add test for printing documentation

CoveMB and others added 30 commits February 20, 2025 20:04
@CoveMB CoveMB requested review from ericglau and ericnordelo May 26, 2025 17:26
Copy link
Member

@ericglau ericglau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
Note this should also be added to cairo_alpha (could be in this PR or a separate PR)

@CoveMB CoveMB requested a review from immrsd June 6, 2025 14:56
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, the changes look good to me. I wonder if we should use this NatSpec format keeping in mind that we don't follow that standard for comments in Starknet. Maybe something like the following is enough?

/// Security contact: [email protected]

Copy link
Contributor

@immrsd immrsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CoveMB
Copy link
Contributor Author

CoveMB commented Jun 13, 2025

@ericnordelo thanks for the guidance, made the changes just double checking, using // or ///?

Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CoveMB CoveMB merged commit d3bc0e1 into OpenZeppelin:master Jun 20, 2025
16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cairo: Add security contact field

4 participants