-
Notifications
You must be signed in to change notification settings - Fork 185
Cairo add security contract field #558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cairo add security contract field #558
Conversation
Co-authored-by: Eric Lau <[email protected]>
ericglau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Note this should also be added to cairo_alpha (could be in this PR or a separate PR)
ericnordelo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, the changes look good to me. I wonder if we should use this NatSpec format keeping in mind that we don't follow that standard for comments in Starknet. Maybe something like the following is enough?
/// Security contact: [email protected]
immrsd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@ericnordelo thanks for the guidance, made the changes just double checking, using |
ericnordelo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #440 (for Cairo and Cairo-alpha only)