Skip to content

Better input error UI #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CoveMB merged 33 commits into from
May 26, 2025
Merged

Better input error UI #557

CoveMB merged 33 commits into from
May 26, 2025

Conversation

@CoveMB
Copy link
Contributor

@CoveMB CoveMB commented May 26, 2025 •
edited
Loading

Partially address issue #312

  • Keep the tooltip error visible until error is resolved
  • Prevent copying and opening to remix was already disabled on error present
  • Displaying multiple errors will need a wider refactor of buildGeneric that currently throw single error
  • Clean up unused ToggleRadio import in StablecoinControls.svelte

CoveMB and others added 30 commits February 20, 2025 20:04
@CoveMB
Before running with prettier
27ebf04
@CoveMB
After running with prettier
7c7828e
@CoveMB
Add consistent-type-imports rule
ce5fcd3
@CoveMB
Add lint step in ci action
3cd0b59
@CoveMB
resolve prettier conflict
31f0c78
@CoveMB
After running with prettier
365421b
@CoveMB
resolve prettier conflict
cedaeaa
@CoveMB
Add lint step in ci action
98bd8af
@CoveMB
resolve prettier conflict
a9098d0
@CoveMB
resolve prettier conflict
6e9df26
@CoveMB
Remove .vscode directory from Git tracking
574a739
@CoveMB
move linter action in it's own job
c0e9002
@CoveMB
add lint note in readme
86c65dc
@CoveMB @ericglau
Update .github/workflows/test.yml
a1111d3 
Co-authored-by: Eric Lau <[email protected]>
@CoveMB
Merge remote-tracking branch 'upstream/master'
abbd5a4
@ericglau
Merge branch 'master' into master
beffa34
@CoveMB
lint script files
d6bec2a
@CoveMB
Merge branch 'master' of github.com:CoveMB/contracts-wizard
315b775
@CoveMB
Merge remote-tracking branch 'upstream/master'
6ed6e4f
@CoveMB
Merge remote-tracking branch 'upstream/master'
ea90cd1
@CoveMB
Merge remote-tracking branch 'upstream/master'
abf687a
@CoveMB
Merge remote-tracking branch 'upstream/master'
426b62d
@CoveMB
Merge remote-tracking branch 'upstream/master'
ea25cc1
@CoveMB
Merge remote-tracking branch 'upstream/master'
0911f87
@CoveMB
Merge remote-tracking branch 'upstream/master'
4914083
@CoveMB
Merge remote-tracking branch 'upstream/master'
5ce527f
@CoveMB
Merge remote-tracking branch 'upstream/master'
03a32fc
@CoveMB
Merge remote-tracking branch 'upstream/master'
b3c0347
@CoveMB
Merge remote-tracking branch 'upstream/master'
0a52a65
@CoveMB
Merge remote-tracking branch 'upstream/master'
9e74342
@CoveMB CoveMB requested a review from ericglau May 26, 2025 14:37
@CoveMB CoveMB enabled auto-merge (squash) May 26, 2025 14:57
@CoveMB CoveMB merged commit 6789092 into OpenZeppelin:master May 26, 2025
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ericglau ericglau ericglau approved these changes

@NicoMolinaOZ NicoMolinaOZ NicoMolinaOZ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CoveMB @ericglau @NicoMolinaOZ