Skip to content

Conversation

@CoveMB
Copy link
Contributor

@CoveMB CoveMB commented Feb 21, 2025

Add eslint and required packages.
Add recommended eslint configuration (including prettier and unicorn) for various files type (similarly to what is found in openzeppelin-upgrades).
Make changes so that the current codebase complies with added lint rules.
Add lint step in CI action.
Run linter with --fix to adjust prettier rules.

Fixes #429
Fixes #446

@socket-security
Copy link

socket-security bot commented Feb 21, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] None 0 48.3 kB nicolo-ribaudo
npm/@eslint-community/[email protected] None +1 410 kB eslint-community-bot
npm/@eslint-community/[email protected] None 0 473 kB eslint-community-bot
npm/@eslint/[email protected] Transitive: environment +1 357 kB eslintbot, openjsfoundation
npm/@eslint/[email protected] None 0 65.1 kB eslintbot
npm/@eslint/[email protected] None +1 79.3 kB
npm/@eslint/[email protected] None 0 14.9 kB eslintbot, openjsfoundation
npm/@eslint/[email protected] None 0 57 kB eslintbot, openjsfoundation
npm/@eslint/[email protected] None 0 77.3 kB eslintbot
npm/@humanfs/[email protected] None 0 72.7 kB nzakas
npm/@humanfs/[email protected] None +1 89.5 kB nzakas
npm/@humanwhocodes/[email protected] unsafe 0 21.2 kB nzakas
npm/@humanwhocodes/[email protected] None 0 65 kB nzakas
npm/@pkgr/[email protected] None 0 8.54 kB jounqin
npm/@types/[email protected] None 0 31.7 kB types
npm/@types/[email protected] None 0 5.81 kB types
npm/@typescript-eslint/[email protected] None 0 2.86 MB bradzacher, jameshenry
npm/@typescript-eslint/[email protected] None 0 19 kB bradzacher, jameshenry
npm/@typescript-eslint/[email protected] None 0 624 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 126 kB bradzacher, jameshenry
npm/@typescript-eslint/[email protected] None 0 175 kB bradzacher, jameshenry
npm/@typescript-eslint/[email protected] Transitive: environment +1 1.03 MB bradzacher, jameshenry
npm/@typescript-eslint/[email protected] None 0 283 kB bradzacher, jameshenry
npm/@typescript-eslint/[email protected] None 0 19.4 kB bradzacher, jameshenry
npm/[email protected] None 0 24.4 kB rreverser
npm/[email protected] eval 0 929 kB esp
npm/[email protected] Transitive: environment, filesystem, network, shell, unsafe +101 7.01 MB novemberborn
npm/[email protected] None 0 3.78 kB sindresorhus
npm/[email protected] None 0 6.33 kB sindresorhus
npm/[email protected] None 0 8.54 kB samverschueren
npm/[email protected] None 0 768 kB zloirock
npm/[email protected] environment, filesystem, shell 0 16.1 kB satazor
npm/[email protected] 🔁 npm/[email protected] None 0 157 kB kilianvalkhof
npm/[email protected] None 0 59.4 kB jounqin, lydell, thorn0
npm/[email protected] None 0 34.5 kB bpscott, jounqin, lydell, ...3 more
npm/[email protected] None +1 923 kB fisker, sindresorhus
npm/[email protected] None 0 152 kB eslintbot
npm/[email protected] None 0 36.1 kB eslintbot
npm/[email protected] None 0 0 B
npm/[email protected] None +1 1.07 MB michaelficarra
npm/[email protected] None 0 13.5 kB michaelficarra
npm/[email protected] None 0 17 kB esp
npm/[email protected] filesystem 0 16 kB jaredwray
npm/[email protected] filesystem 0 29.3 kB jaredwray
npm/[email protected] None 0 31.5 kB webreflection
npm/[email protected] None 0 7.72 kB phated
npm/[email protected] None 0 117 kB sindresorhus
npm/[email protected] None 0 812 kB mattpauldavies
npm/[email protected] None 0 26.6 kB npm-cli-ops
npm/[email protected] 🔁 npm/[email protected] None 0 4.87 kB sindresorhus
npm/[email protected] None 0 4.01 kB sindresorhus
npm/[email protected] None 0 3.94 kB sindresorhus
npm/[email protected] None 0 15.1 kB lydell
npm/[email protected] None 0 32.3 kB mathias
npm/[email protected] None 0 5.4 kB dominictarr
npm/[email protected] None 0 19.6 kB esp
npm/[email protected] None 0 14.2 kB samn
npm/[email protected] None 0 27.8 kB jaredwray
npm/[email protected] None +1 46.1 kB gkz
npm/[email protected] None 0 54.1 kB jdalton
npm/[email protected] None 0 2.97 kB thejameskyle
npm/[email protected] None 0 5.65 kB megawac
npm/[email protected] None 0 28.2 kB npm-cli-ops
npm/[email protected] None 0 50.2 kB gkz
npm/[email protected] None 0 3.92 kB sindresorhus
npm/[email protected] 🔁 npm/[email protected] None 0 9.52 kB sindresorhus
npm/[email protected] None 0 17.7 kB blakeembrey
npm/[email protected] None 0 36.7 kB gkz
npm/[email protected] None 0 9.58 kB bpscott
npm/[email protected] None 0 7.88 MB prettier-bot
npm/[email protected] None 0 33.5 kB google-wombot
npm/[email protected] None 0 6.28 kB sindresorhus
npm/[email protected] None 0 6.92 kB sindresorhus
npm/[email protected] None 0 314 kB dmitrysoshnikov
npm/[email protected] None +1 105 kB jviereck
npm/[email protected] filesystem, unsafe 0 4.64 kB sindresorhus
npm/[email protected] environment, filesystem Transitive: shell +16 2.32 MB isaacs
npm/[email protected] None 0 2.56 kB kevva
npm/[email protected] None 0 23.4 kB kemitchell
npm/[email protected] None 0 3.47 kB kemitchell
npm/[email protected] None 0 11.8 kB kemitchell
npm/[email protected] None 0 12.9 kB kemitchell, shinnn
npm/[email protected] None 0 3.64 kB sindresorhus
npm/[email protected] environment 0 59.8 kB jounqin
npm/[email protected] None 0 354 kB joshuakgoldberg
npm/[email protected] None 0 420 kB sindresorhus
npm/[email protected] None 0 103 kB jameshenry
npm/[email protected] None 0 3.45 kB sindresorhus
npm/[email protected] 🔁 npm/[email protected] None 0 14.8 kB ai
npm/[email protected] None 0 470 kB garycourt
npm/[email protected] None 0 16.6 kB kemitchell

🚮 Removed packages: npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@socket-security
Copy link

socket-security bot commented Feb 21, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@ericglau
Copy link
Member

@SocketSecurity ignore npm/[email protected]
Unrelated to this PR, see #421 (comment)

@ericglau
Copy link
Member

@SocketSecurity ignore npm/[email protected]

Unrelated to this PR, see #430 (comment)

Copy link
Member

@ericglau ericglau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, thanks @CoveMB! Can you add some content under the Development section of README.md on how to run lint and lint --fix?

Copy link
Member

@ericglau ericglau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@CoveMB CoveMB enabled auto-merge (squash) February 21, 2025 21:06
@CoveMB CoveMB disabled auto-merge February 21, 2025 21:51
@CoveMB CoveMB merged commit 72a1f47 into OpenZeppelin:master Feb 24, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add TS linter rule when import not used as value Add TypeScript linter

2 participants