-
Notifications
You must be signed in to change notification settings - Fork 185
Add linter (and formatter through eslint), config and ci action step #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
|
@SocketSecurity ignore npm/[email protected] |
|
@SocketSecurity ignore npm/[email protected] Unrelated to this PR, see #430 (comment) |
ericglau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great, thanks @CoveMB! Can you add some content under the Development section of README.md on how to run lint and lint --fix?
ericglau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Co-authored-by: Eric Lau <[email protected]>
Add eslint and required packages.
Add recommended eslint configuration (including prettier and unicorn) for various files type (similarly to what is found in openzeppelin-upgrades).
Make changes so that the current codebase complies with added lint rules.
Add lint step in CI action.
Run linter with --fix to adjust prettier rules.
Fixes #429
Fixes #446