Skip to content

Conversation

@andrew-fleming
Copy link
Contributor

This PR proposes to move the votes logic to common-components. This PR also proposes to include votes functionality for erc721.

I ran yarn run update_scarb_project on the test project and compiled...after 24 short minutes, there are no errors or warnings :)

Copy link
Member

@ericglau ericglau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in terms of the Wizard code, thanks!
I did not fully review the generated output though, it would be good if someone else can review those.

@ericnordelo
Copy link
Member

Hey @ericglau I reviewed the output, refactored the hooks a bit, and compiled locally. Why can't I see the deploy preview though, does every commit need to be approved?. Note that is harder to review without it even for myself.

@ericnordelo
Copy link
Member

Btw it took me 66 minutes to compile 😢

Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@immrsd immrsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@socket-security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@openzeppelin/[email protected] None 0 1.31 MB amxx
npm/@openzeppelin/[email protected] None 0 1.97 MB ernestognw
npm/[email protected] None 0 2.62 MB alcuadrado, fvictorio, fzeoli, ...3 more
npm/[email protected] None 0 762 kB stuk
npm/[email protected] None 0 237 kB frangio

🚮 Removed packages: npm/[email protected]

View full report↗︎

@socket-security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteCI
High CVE npm/[email protected] 🚫

View full report↗︎

Next steps

What is a CVE?

Contains a high severity Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known high severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@ericglau
Copy link
Member

The rollup issue does not look correct, as I don't see version 2.79.2 being used anywhere in the project.

@SocketSecurity ignore npm/[email protected]

@ericglau ericglau merged commit f8fb22f into OpenZeppelin:master Oct 22, 2024
@github-actions github-actions bot mentioned this pull request Jun 20, 2025
@github-actions github-actions bot mentioned this pull request Aug 20, 2025
This was referenced Sep 9, 2025
@github-actions github-actions bot mentioned this pull request Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants