You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @immrsd, the PR looks good. I want to confirm that you did run yarn run update_scarb_project to update the test_project/, and build with scarb build to ensure there are not warnings or compilation errors with the new addition. Let me know if that's the case.
Hey @immrsd, the PR looks good. I want to confirm that you did run yarn run update_scarb_project to update the test_project/, and build with scarb build to ensure there are not warnings or compilation errors with the new addition. Let me know if that's the case.
Yes, I executed the script and built with scarb --release build, no compilation issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1131.
Test target has been compiled with no issues.