Skip to content

Add ERC721Enumerable #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
immrsd merged 13 commits into from
Sep 26, 2024
Merged

Add ERC721Enumerable #391

immrsd merged 13 commits into from
Sep 26, 2024

Conversation

@immrsd
Copy link
Contributor

@immrsd immrsd commented Sep 23, 2024 •
edited
Loading

Fixes #1131.

Test target has been compiled with no issues.

ericglau
ericglau reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@ericglau ericglau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Just a few comments. Can you also add a changelog entry in an Unreleased section of packages/core-cairo/CHANGELOG.md?

@immrsd
Copy link
Contributor Author

immrsd commented Sep 23, 2024

Looks good, thanks! Just a few comments. Can you also add a changelog entry in an Unreleased section of packages/core-cairo/CHANGELOG.md?

Done!

ericglau
ericglau approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@ericglau ericglau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

andrew-fleming
andrew-fleming approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@andrew-fleming andrew-fleming left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @immrsd! LGTM

@ericnordelo
Copy link
Member

ericnordelo commented Sep 25, 2024

Hey @immrsd, the PR looks good. I want to confirm that you did run yarn run update_scarb_project to update the test_project/, and build with scarb build to ensure there are not warnings or compilation errors with the new addition. Let me know if that's the case.

ericnordelo
ericnordelo reviewed Sep 25, 2024
View reviewed changes
@immrsd
Copy link
Contributor Author

immrsd commented Sep 25, 2024

Hey @immrsd, the PR looks good. I want to confirm that you did run yarn run update_scarb_project to update the test_project/, and build with scarb build to ensure there are not warnings or compilation errors with the new addition. Let me know if that's the case.

Yes, I executed the script and built with scarb --release build, no compilation issues

image

@immrsd immrsd requested a review from ericnordelo September 25, 2024 16:53
@immrsd immrsd merged commit 9280664 into OpenZeppelin:master Sep 26, 2024
@github-actions github-actions bot mentioned this pull request Jun 20, 2025
Merged
@github-actions github-actions bot mentioned this pull request Aug 20, 2025
Merged
This was referenced Sep 9, 2025
Closed
Closed
@github-actions github-actions bot mentioned this pull request Sep 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericglau ericglau ericglau approved these changes

@andrew-fleming andrew-fleming andrew-fleming approved these changes

@ggonzalez94 ggonzalez94 Awaiting requested review from ggonzalez94

@ericnordelo ericnordelo Awaiting requested review from ericnordelo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wizard: ERC721 Enumerable

4 participants

@immrsd @ericnordelo @ericglau @andrew-fleming