Add cairo account #387
Merged
Add cairo account #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericglau
reviewed
Sep 17, 2024
Member
ericglau
left a comment
ericglau
left a comment
There was a problem hiding this comment.
Could you also add an entry in packages/core-cairo/CHANGELOG.md, and add the account type in the API readme at packages/core-cairo/README.md?
Co-authored-by: Eric Lau <[email protected]>
ericnordelo
approved these changes
Sep 18, 2024
Member
ericnordelo
left a comment
ericnordelo
left a comment
There was a problem hiding this comment.
LGTM @andrew-fleming.
Let's not forget to rebuild the test_project (by using yarn run update_scarb_project), and then compile it locally using scarb, to ensure compilation passes without warnings.
Contributor
Author
|
@ericnordelo Done! No issues with compilation |
Merged
Merged
This was referenced Sep 9, 2025
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #376.