Skip to content

Eliminate the big gap from #527 with jQuery and CSS3 #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Martii merged 1 commit into from
Jan 13, 2015
Merged

Eliminate the big gap from #527 with jQuery and CSS3 #528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions views/includes/scripts/commentReplyScript.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,17 @@
<script type="text/javascript">
// Show spacer div
$('#reply-control').on('shown.bs.collapse', function () {
$('#show-reply-form-when-visible').css({
height: '200px'
});
});

// Hide spacer div
$('#reply-control').on('hidden.bs.collapse', function () {
$('#show-reply-form-when-visible').css({
height: '0'
});
});

$('.btn-comment-reply').click(function (aE) {
$('#reply-control').collapse('show');
Expand All @@ -20,7 +33,7 @@
});

function isElementInViewport(aEl) {
//special bonus for those using jQuery
// special bonus for those using jQuery
if (aEl instanceof jQuery) {
aEl = aEl[0];
}
Expand Down Expand Up @@ -53,7 +66,7 @@

var handler = fireIfElementVisible ($('#show-reply-form-when-visible'), callback);

//jQuery
// jQuery
$(window).on('DOMContentLoaded load resize scroll', handler);

</script>
8 changes: 7 additions & 1 deletion views/pages/discussionPage.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,13 @@
{{> includes/head.html }}
<link rel="stylesheet" type="text/css" media="all" href="/redist/npm/bootstrap-markdown/css/bootstrap-markdown.min.css">
<style>
#show-reply-form-when-visible { height: 200px; }
#show-reply-form-when-visible {
-moz-transition: height 1s ease;
-ms-transition: height 1s ease;
-o-transition: height 1s ease;
-webkit-transition: height 1s ease;
transition: height 1s ease;
}
</style>
</head>
<body>
Expand Down
8 changes: 7 additions & 1 deletion views/pages/scriptIssuePage.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,13 @@
<link rel="stylesheet" type="text/css" media="all" href="/redist/npm/bootstrap-markdown/css/bootstrap-markdown.min.css">
<link rel="stylesheet" type="text/css" media="all" href="/css/scriptPage.css">
<style>
#show-reply-form-when-visible { height: 200px; }
#show-reply-form-when-visible {
-moz-transition: height 1s ease;
-ms-transition: height 1s ease;
-o-transition: height 1s ease;
-webkit-transition: height 1s ease;
transition: height 1s ease;
}
</style>
</head>
<body>
Expand Down