Skip to content

Conversation

@MattiSG
Copy link
Member

@MattiSG MattiSG commented Oct 7, 2025

Done in #1189, missed metadata update

@MattiSG MattiSG requested a review from Ndpnt October 7, 2025 13:46
- uses: actions/setup-node@v4
with:
node-version: 20
node-version: 24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer using the oldest supported Node.js version in CI. It’s easy to verify compatibility with the latest version, but I never test with the oldest one locally. This approach ensures the version we claim to support actually works.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Would switching to matrix testing, ensuring testing on the highest and lowest boundaries fulfill that want? 🙂

@Ndpnt Ndpnt merged commit 48ef42a into main Oct 30, 2025
37 of 38 checks passed
@Ndpnt Ndpnt deleted the node-version branch October 30, 2025 08:24
@MattiSG
Copy link
Member Author

MattiSG commented Nov 3, 2025

If at some point we want to speed up build time, I wouldn't be shocked if we only tested on macOS and Windows on Node-latest, and used only UNIX for Node range testing. The risk of an incompatibility existing on a specific platform + specific Node version combination seems low enough to me to justify sparing resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants