Additional laneboundary types to align with OpenDRIVE #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HendrikAmelunxen
added
the
Harmonisation
pmai
reviewed
Oct 19, 2021
osi_lane.proto
Outdated
| // | ||
| TYPE_SOUND_BARRIER = 15; | ||
|
|
||
| // A railing (e.g. divider between road and sidewalk). |
Contributor
There was a problem hiding this comment.
Question: Is this sufficiently distinguished from guard_rail? I.e. a guard rail can also be considered a divider between road and sidewalk in certain situations, however should be mapped to TYPE_GUARD_RAIL, so maybe this should be more clearly stated?
Contributor
Author
There was a problem hiding this comment.
Outcome from the Harmonisation-WG (19.10.2021): Since OpenDRIVE does not use "guard rail" but "railing" instead, a separate "railing" type does not make sense from an alignment point of view => "railing" should be removed.
HendrikAmelunxen
added
the
ReadyForCCBReview
clemenshabedank
approved these changes
Oct 27, 2021
kmeids
added
ReadyToMerge
Signed-off-by: Hendrik Amelunxen <[email protected]>
Limit to types with distance = 0, i.e. continuous objects. Signed-off-by: Hendrik Amelunxen <[email protected]>
Signed-off-by: Hendrik Amelunxen <[email protected]>
pmai
force-pushed
the
feature/laneboundary_types
branch
from
6886d65 to
ddc61dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing additional laneboundary types to align with OpenDRIVE. With this, repeating objects from OpenDRIVE with distance = 0, i.e. continuous objects, can be transformed into laneboundaries.