Skip to content

Conversation

@stefancyliax
Copy link
Contributor

Migration of build pipeline to Github Actions from TravisCI

  • Pipeline was migrated to Github Actions
  • Protobuf updated to current version

@stefancyliax stefancyliax requested a review from pmai April 26, 2021 07:47
@stefancyliax
Copy link
Contributor Author

@pmai Can you review please?
I forked of you and added

  • deploy to gh-pages
  • update to current proto version

Copy link
Contributor

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think those links will work for the badges, it must be keyed off the workflow name.

Other than the screwed up DCO this looks good to me.

@stefancyliax stefancyliax added the ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB. label Apr 28, 2021
@kmeids
Copy link

kmeids commented Apr 28, 2021

Output CCB 28.04.2021:

  1. To be done after the 3.3.1 release.
  2. @pmai please rebase for DCO
  3. @stefancyliax re-do the DCO

@kmeids kmeids removed the ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB. label Apr 28, 2021
@stefancyliax
Copy link
Contributor Author

  1. @stefancyliax re-do the DCO

We discusses that I will merge this after the DCO is sorted out.

@stefancyliax stefancyliax added this to the V3.4.0 milestone May 1, 2021
@stefancyliax
Copy link
Contributor Author

@pmai Could you please rebase to fix DCO?

@stefancyliax stefancyliax added the ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB. label May 12, 2021
@stefancyliax stefancyliax self-assigned this May 12, 2021
@kmeids
Copy link

kmeids commented May 12, 2021

Output CCB 12.05.2021:

  1. @pmai to do the DCO and merge.

@kmeids kmeids added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB. labels May 12, 2021
@pmai pmai closed this May 12, 2021
@pmai pmai reopened this May 12, 2021
@pmai pmai merged commit e37a8c5 into OpenSimulationInterface:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants