fix sloppyness #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using ManualResetEvents instead of a Thread.Sleep for loop it'd be nice if that code didn't have to repeat, but /shrug
miou-gh
reviewed
Sep 22, 2018
Contributor
miou-gh
left a comment
miou-gh
left a comment
There was a problem hiding this comment.
I'll check it out later, from initial impressions it looks fine aside from the formatting. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using ManualResetEvents instead of a Thread.Sleep for loop
ideally, some testing should be done before merging to confirm it works, but the ManualResetEvent behaviour should be working as expected