Open
Conversation
Author
|
Forgot to add a change to the linker used when building the loader: |
This was referenced Jun 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch removes
-Werrorflag so builds don't error out on a unsafe__builtin_frame_address()usage warning (which doesn't seem to matter to Orbis) and some unused variables.It also adds the
-fno-stack-protectorflag, since without it, it requires a implementation for__stack_chk_faildue to Mira being built for a freestanding environment (it could be implemented later if stack protection is desired).Tested under LLVM 16.0.3, on a Base PS4 with firmware 9.00, and on top of the chendo-offset-fix branch.