Skip to content

Enable -fPIC everywhere #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kiwidoggie wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable -fPIC everywhere #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/toolchain.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ jobs:
- name: Build crtlib
run: |
cd src/crt
clang crtlib.c -c -o crtlib.o && mv crtlib.o ../../lib
clang -fPIC crtlib.c -c -o crtlib.o && mv crtlib.o ../../lib

# Merge compiler-rt into libc
- name: Merge compiler-rt into libc
Expand Down
2 changes: 1 addition & 1 deletion build/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ cd /OpenOrbis-PS4-Toolchain/bin/linux && wget https://github.com/maxton/LibOrb
cd /OpenOrbis-PS4-Toolchain/bin/macos && wget https://github.com/maxton/LibOrbisPkg/releases/download/v0.2/PkgTool.Core-osx-x64-0.2.231.zip && unzip PkgTool.Core-osx-x64-0.2.231.zip && rm PkgTool.Core-osx-x64-0.2.231.zip && chmod +x PkgTool.Core

# Copy crtlib
cd /OpenOrbis-PS4-Toolchain/src/crt && as crtlib.S -o crtlib.o && mv crtlib.o /OpenOrbis-PS4-Toolchain/lib
cd /OpenOrbis-PS4-Toolchain/src/crt && as -fPIC crtlib.S -o crtlib.o && mv crtlib.o /OpenOrbis-PS4-Toolchain/lib
Copy link
Copy Markdown
Contributor

@sleirsgoevy sleirsgoevy Sep 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not really make sense for assembly files.


# Copy musl built libs
cd /ps4 && cp -r lib /OpenOrbis-PS4-Toolchain
Expand Down
4 changes: 2 additions & 2 deletions src/crt/build.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
as crt1.s -o crt1.o
as crtlib.s -o crtlib.o
as crt1.s -fPIC -o crt1.o
as crtlib.s -fPIC -o crtlib.o
4 changes: 2 additions & 2 deletions src/crt/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
as crt1.S -o crt1.o
as crtlib.S -o crtlib.o
as crt1.S -fPIC -o crt1.o
as crtlib.S -fPIC -o crtlib.o

mv ./crt1.o ${OO_PS4_TOOLCHAIN}/lib/crt1.o
mv ./crtlib.o ${OO_PS4_TOOLCHAIN}/lib/crtlib.o
Expand Down