Skip to content

Conversation

@cbielow
Copy link
Contributor

@cbielow cbielow commented Dec 22, 2021

Description

followup on #5713

enable creation of distributions from LayerStatistics -- remove a lot of duplicate code in Canvas'

How can I get additional information on failed tests during CI:

If your PR is failing you can check out

Note:

  • Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

Advanced commands (admins / reviewer only):

  • /rebase will try to rebase the PR on the current develop branch.
  • /reformat (experimental) applies the clang-format style changes as additional commit
  • setting the label NoJenkins will skip tests for this PR on jenkins (saves resources e.g., on edits that do not affect tests)

enable creation of distributions from LayerStatistics -- remove a lot of duplicate code in Canvas'
@timosachsenberg
Copy link
Contributor

timosachsenberg commented Dec 22, 2021

there seems to be a merge conflict. attempt of a quick fix

Copy link
Contributor

@timosachsenberg timosachsenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if tests pass

@cbielow
Copy link
Contributor Author

cbielow commented Dec 22, 2021

there seems to be a merge conflict. attempt of a quick fix

thanks!

Seems all good. Will merge.

@cbielow cbielow merged commit fceec07 into OpenMS:develop Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants