Skip to content

Fix branding in JNLP#284

Open
mgaffigan wants to merge 1 commit intoOpenIntegrationEngine:mainfrom
mgaffigan:branding-jnlp
Open

Fix branding in JNLP#284
mgaffigan wants to merge 1 commit intoOpenIntegrationEngine:mainfrom
mgaffigan:branding-jnlp

Conversation

@mgaffigan
Copy link
Copy Markdown
Contributor

JNLP still references MirthConnect, which theoretically controls the icon and name. Images do not exist. current launchers do not use it, but we should have it correct anyway.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

Test Results

  111 files  ±0    214 suites  ±0   7m 1s ⏱️ + 1m 9s
  654 tests ±0    654 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 308 runs  ±0  1 308 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1fcaf13. ± Comparison against base commit be1072d.

♻️ This comment has been updated with latest results.

@mgaffigan mgaffigan marked this pull request as ready for review April 4, 2026 04:25
private static String CORE_JNLP = "<jnlp codebase=\"https://localhost:8443\" version=\"4.5.2\">\n"
+ " <information>\n" + " <title>Mirth Connect Administrator 4.5.2</title>\n"
+ " <vendor>NextGen Healthcare</vendor>\n" + " <homepage href=\"http://www.nextgen.com\"/>\n"
+ " <information>\n" + " <title>Open Integration Engine 4.5.2</title>\n"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might as well bump the version while you are at it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a test fixture. I've submitted #286 to correct the production version being here.

Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants