Skip to content

fix: write remote completion logs as utf-8#3225

Merged
enyst merged 2 commits into
OpenHands:mainfrom
he-yufeng:fix/remote-completion-log-utf8
May 17, 2026
Merged

fix: write remote completion logs as utf-8#3225
enyst merged 2 commits into
OpenHands:mainfrom
he-yufeng:fix/remote-completion-log-utf8

Conversation

@he-yufeng

Copy link
Copy Markdown
Contributor

Summary

  • write RemoteConversation completion logs with explicit UTF-8 encoding on the client
  • add a regression test for non-ASCII completion log data

Addresses OpenHands/OpenHands#14389.

To verify

  • uv run pytest tests\sdk\conversation\remote\test_remote_conversation.py -q --basetemp C:\dev\GITHUB-clean_tmp\software-agent-sdk-pytest
  • uv run ruff check openhands-sdk\openhands\sdk\conversation\impl\remote_conversation.py tests\sdk\conversation\remote\test_remote_conversation.py
  • uv run ruff format --check openhands-sdk\openhands\sdk\conversation\impl\remote_conversation.py tests\sdk\conversation\remote\test_remote_conversation.py
  • uv run pyright openhands-sdk\openhands\sdk\conversation\impl\remote_conversation.py tests\sdk\conversation\remote\test_remote_conversation.py
  • python -m py_compile openhands-sdk\openhands\sdk\conversation\impl\remote_conversation.py tests\sdk\conversation\remote\test_remote_conversation.py
  • git diff --check

@he-yufeng he-yufeng force-pushed the fix/remote-completion-log-utf8 branch from ab56d29 to 3d58687 Compare May 14, 2026 13:29
@he-yufeng

Copy link
Copy Markdown
Contributor Author

Rebased onto current main and resolved the test conflict by keeping both the upstream ACP endpoint coverage and this PR's UTF-8 completion-log regression test.

Validated locally:

  • .venv\Scripts\python.exe -m pytest tests\sdk\conversation\remote\test_remote_conversation.py -q --basetemp C:\dev\GITHUB-clean\_tmp\software-agent-sdk-pytest
  • .venv\Scripts\python.exe -m py_compile openhands-sdk\openhands\sdk\conversation\impl\remote_conversation.py tests\sdk\conversation\remote\test_remote_conversation.py
  • .venv\Scripts\python.exe -m ruff check openhands-sdk\openhands\sdk\conversation\impl\remote_conversation.py tests\sdk\conversation\remote\test_remote_conversation.py
  • git diff --check

@all-hands-bot all-hands-bot requested a review from xingyaoww May 17, 2026 12:43
@all-hands-bot

Copy link
Copy Markdown
Collaborator

[Automatic Post]: I have assigned @xingyaoww as a reviewer based on the repository MAINTAINERS file. Thanks in advance for the help!

@enyst enyst requested a review from all-hands-bot May 17, 2026 13:01

@all-hands-bot all-hands-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean fix for cross-platform UTF-8 compatibility. Brings remote completion logging in line with the existing local telemetry pattern.

@enyst enyst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@enyst enyst merged commit e6aa5bc into OpenHands:main May 17, 2026
32 checks passed
adshrc pushed a commit to adshrc/software-agent-sdk that referenced this pull request May 29, 2026
Co-authored-by: Engel Nyst <engel.nyst@gmail.com>
StressTestor pushed a commit to StressTestor/software-agent-sdk that referenced this pull request Jun 1, 2026
Co-authored-by: Engel Nyst <engel.nyst@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants