fix: Limit mailbox length #190
Merged
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hefloryd
reviewed
Apr 4, 2025
soes/esc.c
Outdated
| #include "esc_coe.h" | ||
| #include "esc_foe.h" | ||
|
|
||
| static_assert((MBXSIZE > ESC_MBXHSIZE) && (MBXSIZEBOOT > ESC_MBXHSIZE), "Mailbox size too small."); |
Contributor
There was a problem hiding this comment.
Please use CC_STATIC_ASSERT for portability to more toolchains. CC_STATIC_ASSERT does not currently take a message however, but since it is not used otherwise in this repo would could add another argument for the message.
Contributor
|
Merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check maximum allowed length of service data for incoming mailbox.
Subsequent mailbox services expect a valid length information to access several positions within the mailbox message buffer.
Validate minimum required configured mailbox size.