feat: create ContractRepository interface, implementation #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ndacyayisenga-droid <[email protected]>
| @NonNull | ||
| default JSON queryContractsByFileId(@NonNull final String fileId) throws HieroException { | ||
| Objects.requireNonNull(fileId, "fileId must not be null"); | ||
| return doGetCall("/api/v1/contracts?file.id=" + fileId); |
Member
There was a problem hiding this comment.
Have you ever tried that endpoints? I can not find a definition for it at https://testnet.mirrornode.hedera.com/api/v1/docs/#/
| @NonNull | ||
| default JSON queryContractsByEvmAddress(@NonNull final String evmAddress) throws HieroException { | ||
| Objects.requireNonNull(evmAddress, "evmAddress must not be null"); | ||
| return doGetCall("/api/v1/contracts?evm.address=" + evmAddress); |
Member
There was a problem hiding this comment.
Have you ever tried that endpoints? I can not find a definition for it at https://testnet.mirrornode.hedera.com/api/v1/docs/#/
| @NonNull | ||
| default JSON queryContractsByProxyAccountId(@NonNull final String proxyAccountId) throws HieroException { | ||
| Objects.requireNonNull(proxyAccountId, "proxyAccountId must not be null"); | ||
| return doGetCall("/api/v1/contracts?proxy.account.id=" + proxyAccountId); |
Member
There was a problem hiding this comment.
Have you ever tried that endpoints? I can not find a definition for it at https://testnet.mirrornode.hedera.com/api/v1/docs/#/
| } | ||
| final JsonArray contractsArray = jsonObject.getJsonArray("contracts"); | ||
| if (contractsArray == null) { | ||
| throw new IllegalArgumentException("Contracts array is not an array: " + contractsArray); |
Member
There was a problem hiding this comment.
Suggested change
| throw new IllegalArgumentException("Contracts array is not an array: " + contractsArray); | |
| throw new IllegalArgumentException("No contracts array in JSON"); |
| if (contractsArray == null) { | ||
| throw new IllegalArgumentException("Contracts array is not an array: " + contractsArray); | ||
| } | ||
| Spliterator<JsonValue> spliterator = Spliterators.spliteratorUnknownSize(contractsArray.iterator(), |
Member
There was a problem hiding this comment.
Suggested change
| Spliterator<JsonValue> spliterator = Spliterators.spliteratorUnknownSize(contractsArray.iterator(), | |
| final Spliterator<JsonValue> spliterator = Spliterators.spliteratorUnknownSize(contractsArray.iterator(), |
| } | ||
|
|
||
| // Simple Page implementation for converter methods | ||
| private static class SimplePage<T> implements Page<T> { |
Member
There was a problem hiding this comment.
Suggested change
| private static class SimplePage<T> implements Page<T> { | |
| private static class SinglePage<T> implements Page<T> { |
We should extract that class to an extra file since others might want to use it as well
| private static class SimplePage<T> implements Page<T> { | ||
| private final List<T> data; | ||
|
|
||
| public SimplePage(List<T> data) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.