Replace polling with Watch API in waitForPartialChunk #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
waitForPartialChunkfunction used a polling loop withtime.Sleep(time.Second)to check for chunk completion. This is inefficient and not aligned with Kubernetes client-go best practices.Changes
FieldSelectorto watch specific chunk by nameBefore:
After:
No changes to webui or controller event handlers - those use appropriate patterns for their use cases (SSE streaming and controller reconciliation respectively).
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/OpenCIDN/ocimirror/branchescurl -s REDACTED(http block)https://api.github.com/repos/OpenCIDN/ocimirror/commitscurl -s REDACTED(http block)https://api.github.com/repos/OpenCIDN/ocimirror/pullscurl -s REDACTED(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.