Skip to content

Conversation

@jmthomas
Copy link
Member

closes #2520
closes #2521

@jmthomas jmthomas requested a review from ryanmelt November 12, 2025 02:36
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 73.33333% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.59%. Comparing base (a33514e) to head (9986575).

Files with missing lines Patch % Lines
...s-cmd-tlm-api/app/controllers/queues_controller.rb 28.57% 10 Missing ⚠️
openc3/lib/openc3/api/cmd_api.rb 0.00% 1 Missing ⚠️
openc3/lib/openc3/models/queue_model.rb 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2535      +/-   ##
==========================================
- Coverage   79.60%   79.59%   -0.02%     
==========================================
  Files         658      658              
  Lines       50463    50494      +31     
  Branches      736      736              
==========================================
+ Hits        40171    40190      +19     
- Misses      10212    10224      +12     
  Partials       80       80              
Flag Coverage Δ
python 81.57% <ø> (-0.02%) ⬇️
ruby-api 84.32% <28.57%> (-0.22%) ⬇️
ruby-backend 82.94% <93.54%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@clayandgen clayandgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes for #2520 verified ✅

For #2521 I have OPENC3_DEFAULT_QUEUE=DEFAULT set and it looks like the format of how these commands are saved changes, and not appearing well on the Command Queue UI.
Screenshot 2025-11-20 at 4 25 11 PM
Screenshot 2025-11-20 at 4 25 03 PM

@jmthomas
Copy link
Member Author

@clayandgen you need to be using this PR from Enterprise to test the changes: https://github.com/OpenC3/cosmos-enterprise/pull/362

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editable Command History ignores queue=False Buggy behavior with Editable Cmd History in Cmd Sender for (cmd validation)

3 participants