Skip to content

Conversation

@4brunu
Copy link
Contributor

@4brunu 4brunu commented Jan 25, 2021

The objc integration in the is broken, which was making CI to fail.
This PR fixes that.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

@wing328
Copy link
Member

wing328 commented Jan 25, 2021

bitrise tests passed: https://app.bitrise.io/build/77042cf4574742b0

@wing328 wing328 merged commit 17bb375 into OpenAPITools:master Jan 25, 2021
@4brunu 4brunu deleted the feature/swift5-fix-objc-integration branch January 25, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants