Skip to content

Conversation

@cal101
Copy link
Contributor

@cal101 cal101 commented Jan 17, 2021

Collection related refactorings:

  • replaces for/foreach loops to use Collections.addAll() where
    possible,
  • replaces for/foreach loops to use Collection.addAll() where possible,
  • replaces for/foreach loops to use Collection.removeAll() where
    possible.

AddAllRatherThanLoopCleanUp from AutoRefactor applied by erefactor.
For AutoRefactor see https://github.com/JnRouvignac/AutoRefactor .

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

Collection related refactorings:
- replaces for/foreach loops to use Collections.addAll() where
possible,
- replaces for/foreach loops to use Collection.addAll() where possible,
- replaces for/foreach loops to use Collection.removeAll() where
possible.

AddAllRatherThanLoopCleanUp from AutoRefactor applied by erefactor.
For AutoRefactor see https://github.com/JnRouvignac/AutoRefactor .
@wing328
Copy link
Member

wing328 commented Jan 18, 2021

cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

@topce
Copy link
Contributor

topce commented Jan 25, 2021

LGTM

@wing328 wing328 added Client: TypeScript Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Jan 25, 2021
@wing328 wing328 added this to the 5.0.1 milestone Jan 25, 2021
@wing328 wing328 merged commit 8a95525 into OpenAPITools:master Jan 25, 2021
@wing328 wing328 changed the title erefactor - AutoRefactor - Collections.addAll() rather than loop [typescript] use Collections.addAll() rather than loop Jan 25, 2021
@cal101 cal101 deleted the erefactor/AddAllRatherThanLoopCleanUp branch January 26, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client: TypeScript Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants