Skip to content

Conversation

@gasugesu
Copy link
Contributor

@gasugesu gasugesu commented Dec 16, 2020

It would be best for us to locate circle ci config file into .circleci/config.yml because we are using CircleCI v2.

https://circleci.com/docs/2.0/configuration-reference/

スクリーンショット 2020-12-16 22 59 28

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 wing328 merged commit 145d9c3 into OpenAPITools:master Dec 16, 2020
@wing328 wing328 added this to the 5.0.0 milestone Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants