Skip to content

Conversation

@ityuhui
Copy link
Contributor

@ityuhui ityuhui commented Dec 15, 2020

Sometimes, the model is not created completely due to some error (e.g. JSON string of a data field of the model cannot be parsed). Only a part of model is created.

At this time, we need check whether the pointer pointing to the data field is valid to avoid core-dump before releasing its memory.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 @zhemant @michelealbano

@auto-labeler
Copy link

auto-labeler bot commented Dec 15, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328 wing328 added this to the 5.0.0 milestone Dec 16, 2020
@wing328
Copy link
Member

wing328 commented Dec 16, 2020

CircleCI failure not related to this change.

@wing328 wing328 merged commit f0c4fd7 into OpenAPITools:master Dec 16, 2020
@ityuhui ityuhui deleted the yh-fix-coredump-when-release-memory branch December 16, 2020 13:30
@ityuhui
Copy link
Contributor Author

ityuhui commented Dec 16, 2020

Thank you @agilob @wing328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants