-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
[Java][Client]com.github.curious-odd-man.rgxgen version update #8139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java][Client]com.github.curious-odd-man.rgxgen version update #8139
Conversation
|
New error encountered: a testcase failed |
Can you strip any leading and trailing / and / from the regex pattern before it is passed into rxgen? That will solve this problem. |
spacether
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR! This looks great!
|
Hello @spacether and @code-lucidal58. I've got a feeling that the fix is incorrect: I think that instead of: there should be: i.e. when ends with slash - truncate from end, when starts with slash - truncate from start. |
|
Pardon me for this silly mistake. Here is the edit: #8219 |

Fix Rxgen version update
Pattern string
^[a-zA-Z0-9-._:]*$could not be processed in the 1.1 version of library. The issue was fixed here: curious-odd-man/RgxGen#53PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)