[dart-dio] fixes Enum classes with integer values #8129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ueEnumConst annotation
Contributor
Author
|
Fixes #6955 |
kuhnroyal
suggested changes
Dec 8, 2020
|
|
||
| static BuiltSet<{{classname}}{{nameInCamelCase}}> get values => _${{classVarName}}{{nameInCamelCase}}Values; | ||
| static {{classname}}{{nameInCamelCase}} valueOf(String name) => _${{classVarName}}{{nameInCamelCase}}ValueOf(name); | ||
| } |
Contributor
There was a problem hiding this comment.
Probably revert this line
| static const EnumTestEnumInteger number1 = _$number1; | ||
| @BuiltValueEnumConst(wireName: -1) | ||
| @BuiltValueEnumConst(wireNumber: -1) | ||
| static const EnumTestEnumInteger number1 = _$number1; |
Contributor
There was a problem hiding this comment.
FYI just noticed 2 times $number1 here. My changes also don't fix this yet. Need to address this seperatly.
| /// {{description}} | ||
| {{/description}} | ||
| @BuiltValueEnumConst(wireName: {{{value}}}) | ||
| @BuiltValueEnumConst({{#isInteger}}wireNumber: {{{value}}}{{/isInteger}}{{#isString}}wireName: {{{value}}}{{/isString}}) |
Contributor
There was a problem hiding this comment.
Use {{^isInteger}} to prevent the double enum from failing.
| @BuiltValueEnumConst(wireName: '1.1') | ||
| @BuiltValueEnumConst() | ||
| static const EnumTestEnumNumber 11_ = _$11_; | ||
| @BuiltValueEnumConst(wireName: '-1.2') |
Contributor
There was a problem hiding this comment.
See above comment in template. Sadly wireNumber: doesn't support num/double. Probably need to add a custom serializer for this at some point.
kuhnroyal
approved these changes
Dec 8, 2020
wing328
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enum classes with integer values now generate correct BuiltValueEnumConst annotation
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master@ircecho @swipesight @jaumard @athornz @amondnet @kuhnroyal